From: Jack Yu <jack.yu@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH 1/2] ASoC: rt1320-sdw: kcontrol for brown-out feature update
Date: Tue, 7 Apr 2026 09:08:33 +0000 [thread overview]
Message-ID: <b58acdb490524d22a229914a7b63f03a@realtek.com> (raw)
In-Reply-To: <55886bf3-5837-4f37-b60d-333fdc5f5f70@sirena.org.uk>
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Thursday, April 2, 2026 7:46 PM
> To: Jack Yu <jack.yu@realtek.com>
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu) <flove@realtek.com>; Oder Chiou <oder_chiou@realtek.com>;
> Shuming [范書銘] <shumingf@realtek.com>; Derek [方德義]
> <derek.fang@realtek.com>
> Subject: Re: [PATCH 1/2] ASoC: rt1320-sdw: kcontrol for brown-out feature
> update
>
> On Thu, Apr 02, 2026 at 01:47:15PM +0800, jack.yu@realtek.com wrote:
>
> > + SOC_SINGLE_EXT("Brown Out Update", SND_SOC_NOPM, 0, 1, 0,
> > + rt1320_brown_out_get, rt1320_brown_out_put),
>
> Like I say this should be a Switch - it's an on/off control, even if it's for an
> algorithm.
Do you mean I should use "Brown Out Switch" instead of "Brown Out Update"?
And still use SOC_SINGLE_EXT for declaration, like below
SOC_SINGLE_EXT("Brown Out Switch", SND_SOC_NOPM, 0, 1, 0,
rt1320_brown_out_get, rt1320_brown_out_put)
next prev parent reply other threads:[~2026-04-07 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 5:47 [PATCH 1/2] ASoC: rt1320-sdw: kcontrol for brown-out feature update jack.yu
2026-04-02 5:47 ` [PATCH 2/2] ASoC: rt1320-sdw: Add an approach to get new hardware advance gain jack.yu
2026-04-02 11:46 ` [PATCH 1/2] ASoC: rt1320-sdw: kcontrol for brown-out feature update Mark Brown
2026-04-07 9:08 ` Jack Yu [this message]
2026-04-07 10:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b58acdb490524d22a229914a7b63f03a@realtek.com \
--to=jack.yu@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox