From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lucas Stach <l.stach@pengutronix.de>, Marek Vasut <marex@denx.de>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
Markus Niebel <Markus.Niebel@ew.tq-group.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Adam Ford <aford173@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Mark Brown <broonie@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Tim Harvey <tharvey@gateworks.com>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order
Date: Fri, 6 Jan 2023 10:24:05 +0100 [thread overview]
Message-ID: <b74b4438-9496-f636-995b-4acdba5766f1@linaro.org> (raw)
In-Reply-To: <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de>
On 06/01/2023 10:18, Lucas Stach wrote:
> Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut:
>> Swap the SAI dmas and dma-names to match the order documented in
>> Documentation/devicetree/bindings/sound/fsl,sai.yaml
>> No functional change.
>>
> While I'm not opposing this patch, I find this class of changes a bit
> odd. The *-names properties are there so the properties they are naming
> can be in any order in the DT without impacting the lookup. Enforcing a
> fixed order for named properties just feels odd.
DT requires fixed order regardless of '-names' property. '-names' are
not there to fulfill "can be in any order", but merely a helper.
>
> Not sure if the schema validation could take this into account or if
> there is any policy in place already by the DT maintainer that we still
> want to enforce the same order in the DTs as in the bindings.
The order in DTS must obviously match bindings, however here both are
changed, so what is exactly your concern?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-06 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 14:41 [PATCH 1/2] ASoC: dt-bindings: fsl-sai: Simplify the VFxxx dmas binding Marek Vasut
2023-01-05 14:41 ` [PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order Marek Vasut
2023-01-06 9:18 ` Lucas Stach
2023-01-06 9:24 ` Krzysztof Kozlowski [this message]
2023-01-25 23:57 ` Shawn Guo
2023-01-06 9:16 ` [PATCH 1/2] ASoC: dt-bindings: fsl-sai: Simplify the VFxxx dmas binding Krzysztof Kozlowski
2023-01-30 21:00 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74b4438-9496-f636-995b-4acdba5766f1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=aford173@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=peng.fan@nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=stefan@agner.ch \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).