From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C845C4332F for ; Sun, 16 Oct 2022 07:31:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BEA7E81E5; Sun, 16 Oct 2022 09:30:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BEA7E81E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665905477; bh=eeChTA5PncoSikGu9ALHNXz0gxFiLBJ0Au+07rl/SIk=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RHvF7vEcV19d0WhKTLngyV+EqDX0nQ2y5AfpF/naJelAUmE6tY+UgykBrUkC0xqeU 7iqrMGEO2rTV3FwOihQKUh1hfh/iwIAHa8BMyw3XeLUeYbCG1vxc1fPVgWvGnZgWej MVNbL05ZK3oJIe6yJEi/0lUAmdiJ6LXCNuKzU+Js= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1AF23F8055B; Sun, 16 Oct 2022 09:28:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A4D67F800C0; Thu, 13 Oct 2022 03:23:23 +0200 (CEST) Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2EA9EF800C0 for ; Thu, 13 Oct 2022 03:23:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2EA9EF800C0 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R631e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045192; MF=baolin.wang@linux.alibaba.com; NM=1; PH=DS; RN=98; SR=0; TI=SMTPD_---0VS19mRS_1665624179; Received: from 30.97.48.54(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VS19mRS_1665624179) by smtp.aliyun-inc.com; Thu, 13 Oct 2022 09:23:04 +0800 Message-ID: Date: Thu, 13 Oct 2022 09:23:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 23/36] pinctrl: sprd: Add missed header(s) To: Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Kent Gibson , Mauro Carvalho Chehab , Billy Tsai , Thomas Gleixner , Linus Walleij , Mika Westerberg , AngeloGioacchino Del Regno , Chen-Yu Tsai , Claudiu Beznea , Samuel Holland , Horatiu Vultur , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Lad Prabhakar , Phil Edworthy , Krzysztof Kozlowski , Fabien Dessenne , Prathamesh Shete , Basavaraj Natikar , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-24-andriy.shevchenko@linux.intel.com> From: Baolin Wang In-Reply-To: <20221010201453.77401-24-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 16 Oct 2022 09:28:43 +0200 Cc: Andrew Lunn , Alexandre Belloni , Jacky Bai , Kunihiko Hayashi , Tony Lindgren , Konrad Dybcio , Alexandre Torgue , Tali Perry , Paul Cercueil , Thierry Reding , Haojian Zhuang , Fabio Estevam , Michal Simek , Tomer Maimon , Florian Fainelli , Benjamin Fair , soc@kernel.org, Viresh Kumar , Gregory Clement , Chen-Yu Tsai , Jonathan Hunter , Nancy Yuen , Ludovic Desroches , Andy Gross , Broadcom internal kernel review list , Joel Stanley , Orson Zhai , Alim Akhtar , Patrice Chotard , NXP Linux Team , Andy Shevchenko , Charles Keepax , Maxime Coquelin , Manivannan Sadhasivam , Ray Jui , Sascha Hauer , Tomasz Figa , Richard Fitzgerald , Shiraz Hashim , Dong Aisheng , Damien Le Moal , Scott Branden , Andrew Jeffery , Patrick Venture , Sean Wang , Nicolas Ferre , Avi Fishman , Masami Hiramatsu , Pengutronix Kernel Team , Chunyan Zhang , Emil Renner Berthing , Sebastian Hesselbarth , Shawn Guo , =?UTF-8?Q?Andreas_F=c3=a4rber?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/11/2022 4:14 AM, Andy Shevchenko wrote: > Do not imply that some of the generic headers may be always included. > Instead, include explicitly what we are direct user of. > > While at it, sort headers alphabetically. > > Signed-off-by: Andy Shevchenko LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/pinctrl/sprd/pinctrl-sprd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c > index dca7a505d413..c1806b7dcf78 100644 > --- a/drivers/pinctrl/sprd/pinctrl-sprd.c > +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c > @@ -13,12 +13,14 @@ > #include > #include > #include > +#include > + > +#include > #include > -#include > #include > +#include > #include > #include > -#include > > #include "../core.h" > #include "../pinmux.h"