From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name' Date: Mon, 6 May 2019 10:50:52 -0500 Message-ID: References: <20190504151652.5213-1-user@elitebook-localhost> <20190504151652.5213-4-user@elitebook-localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede , Takashi Iwai , Nariman Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Jordy Ubink , broonie@kernel.org, liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com, perex@perex.cz List-Id: alsa-devel@alsa-project.org On 5/6/19 10:40 AM, Hans de Goede wrote: > Hi, > > On 05-05-19 09:51, Takashi Iwai wrote: >> On Sat, 04 May 2019 17:16:52 +0200, >> Nariman wrote: >>> >>> From: Jordy Ubink >>> >>> The snprintf calls filling byt_rt5651_cpu_dai_name / >>> byt_rt5651_cpu_dai_name always fill them with the same string >>> (ssp0-port" resp "rt5651-aif2"). So instead of keeping these buffers >>> around and making the cpu_dai_name / codec_dai_name point to this, >>> simply update the foo_dai_name pointers to directly point to a string >>> constant containing the desired string. >>> >>> Signed-off-by: Jordy Ubink >> >> If you submit a patch, please give your own sign-off as well as the >> author's one, even if the patch is not written by you.  This is a >> legal requirement. > > Sorry, that is my bad, Nariman and the author authors of the patches > are a group of students doing some kernel work for me and this is > a warm-up assignment for them to get used to the kernel development > process. > > I forgot to point out to Nariman that since he is sending > out the entire series for all 4 of them, he needs to add his > S-o-b. One suggestion for additional cleanups: can we try and remove all these static variables and move them to the context structure? It's been on my TODO list for a while.