From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: SOF: Fix a compile warning with CONFIG_PCI=n
Date: Mon, 06 May 2019 11:21:57 -0700 [thread overview]
Message-ID: <b8f759f63a64b7e9ea21ae8b659a5e1d5ff294df.camel@linux.intel.com> (raw)
In-Reply-To: <20190506150224.1394-3-tiwai@suse.de>
On Mon, 2019-05-06 at 17:02 +0200, Takashi Iwai wrote:
> A trivial fix for the randconfig build error:
> sound/soc/sof/ops.c:20:6: warning: ‘ret’ is used uninitialized in
> this function [-Wuninitialized]
Looks good. Thanks, Takashi.
Ranjani
>
> Fixes: d1d95fcb63e3 ("ASoC: SOF: Add DSP HW abstraction operations")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/soc/sof/ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ops.c b/sound/soc/sof/ops.c
> index 80f907740b82..7a27c3b719e7 100644
> --- a/sound/soc/sof/ops.c
> +++ b/sound/soc/sof/ops.c
> @@ -17,7 +17,7 @@ bool snd_sof_pci_update_bits_unlocked(struct
> snd_sof_dev *sdev, u32 offset,
> {
> struct pci_dev *pci = to_pci_dev(sdev->dev);
> unsigned int old, new;
> - u32 ret;
> + u32 ret = 0;
>
> pci_read_config_dword(pci, offset, &ret);
> old = ret;
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-05-06 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 15:02 [PATCH 0/3] ASoC: trivial compile warning fixes Takashi Iwai
2019-05-06 15:02 ` [PATCH 1/3] ASoC: da7219: Fix a compile warning at CONFIG_COMMON_CLK=n Takashi Iwai
2019-05-07 2:28 ` Applied "ASoC: da7219: Fix a compile warning at CONFIG_COMMON_CLK=n" to the asoc tree Mark Brown
2019-05-07 2:30 ` Mark Brown
2019-05-06 15:02 ` [PATCH 2/3] ASoC: SOF: Fix a compile warning with CONFIG_PCI=n Takashi Iwai
2019-05-06 15:40 ` Pierre-Louis Bossart
2019-05-06 18:21 ` Ranjani Sridharan [this message]
2019-05-07 2:28 ` Applied "ASoC: SOF: Fix a compile warning with CONFIG_PCI=n" to the asoc tree Mark Brown
2019-05-07 2:30 ` Mark Brown
2019-05-06 15:02 ` [PATCH 3/3] ASoC: rockchip: Fix an uninitialized variable compile warning Takashi Iwai
2019-05-07 2:28 ` Applied "ASoC: rockchip: Fix an uninitialized variable compile warning" to the asoc tree Mark Brown
2019-05-07 2:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f759f63a64b7e9ea21ae8b659a5e1d5ff294df.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox