From: Clemens Ladisch <clemens@ladisch.de>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 18/18] ALSA: opl4: Move inline before return type
Date: Wed, 5 Jul 2017 22:30:05 +0200 [thread overview]
Message-ID: <b917f32c-cacf-10a8-b9d5-b01da8a75992@ladisch.de> (raw)
In-Reply-To: <e19de389484090a3059d17584d5a342db90889e5.1499284835.git.joe@perches.com>
Joe Perches wrote:
> Make the code like the rest of the kernel.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> sound/drivers/opl4/opl4_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/drivers/opl4/opl4_lib.c b/sound/drivers/opl4/opl4_lib.c
> index bc345d564f8d..db76a5bf2bd2 100644
> --- a/sound/drivers/opl4/opl4_lib.c
> +++ b/sound/drivers/opl4/opl4_lib.c
> @@ -29,7 +29,7 @@ MODULE_AUTHOR("Clemens Ladisch <clemens@ladisch.de>");
> MODULE_DESCRIPTION("OPL4 driver");
> MODULE_LICENSE("GPL");
>
> -static void inline snd_opl4_wait(struct snd_opl4 *opl4)
> +static inline void snd_opl4_wait(struct snd_opl4 *opl4)
> {
> int timeout = 10;
> while ((inb(opl4->fm_port) & OPL4_STATUS_BUSY) && --timeout > 0)
next prev parent reply other threads:[~2017-07-05 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: Move inline " Joe Perches
2017-07-05 20:30 ` Clemens Ladisch [this message]
2017-07-06 7:24 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b917f32c-cacf-10a8-b9d5-b01da8a75992@ladisch.de \
--to=clemens@ladisch.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).