From: "Rojewski, Cezary" <cezary.rojewski@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH] ASoC: Intel: Do not load legacy SST driver on BYT when SND_SOC_SOF_BAYTRAIL is enabled
Date: Mon, 12 Oct 2020 07:24:11 +0000 [thread overview]
Message-ID: <b92b6b6d382048829a37ae803d4f9451@intel.com> (raw)
In-Reply-To: <20201011095346.49589-1-hdegoede@redhat.com>
On 2020-10-11 11:53 AM, Hans de Goede wrote:
> The legacy 80860F28 / sst_acpi_baytrail_desc match in sst_acpi_match
> is already conditional on the the newer SND_SST_IPC_ACPI driver not
> being enabled.
>
> But now that we have an even newer driver in the form of SOF support
> for BYT devices, we also need to take this into account, so we also
> must not include the sst_acpi_baytrail_desc match when
> SND_SOC_SOF_BAYTRAIL is enabled.
>
> This fixes snd-soc-sst-acpi binding to the 80860F28 platform device,
> blocking snd-sof-acpi from binding, which breaks audio support.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Hello,
Series:
[PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components
https://lore.kernel.org/alsa-devel/20201006064907.16277-1-cezary.rojewski@intel.com/
removes sst-acpi component along with many others so further changes to
said component will only cause conflicts -or- require commit reordering.
I'd advice against that.
Thanks,
Czarek
next prev parent reply other threads:[~2020-10-12 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 9:53 [PATCH] ASoC: Intel: Do not load legacy SST driver on BYT when SND_SOC_SOF_BAYTRAIL is enabled Hans de Goede
2020-10-12 7:24 ` Rojewski, Cezary [this message]
2020-10-12 7:42 ` Hans de Goede
2020-10-12 7:58 ` Rojewski, Cezary
2020-10-12 8:12 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92b6b6d382048829a37ae803d4f9451@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).