From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: Curtis Malainey <cujomalainey@chromium.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
Alper Nebi Yasak <alpernebiyasak@gmail.com>
Subject: Re: [PATCH 1/2] ucm: Add JackSwitch definition
Date: Sat, 22 Aug 2020 16:48:28 +0300 [thread overview]
Message-ID: <b98a8a77-7652-1995-27ba-eb7b6d30202a@gmail.com> (raw)
In-Reply-To: <20200820233205.505925-1-cujomalainey@chromium.org>
Hi, I'm not really a kernel person, but wanted to point out an
alternative I think is better.
On 21/08/2020 02:32, Curtis Malainey wrote:
> Some codecs can differentiate headsets based on the number of rings.
> Should we choose to differentiate the config we will need to be able to
> select based on the jack event code.
AFAICT from ChromiumOS UCM configs, you're using JackSwitch to detect
whether a plugged-in jack is/has headphones, a headset mic, or line-out.
Instead, if you add something like my recent commit d0508b4f1604 ("ASoC:
rk3399_gru_sound: Add DAPM pins, kcontrols for jack detection") to the
machine drivers, you can just use JackControl to specify them in your
UCM files, and your audio server could distinguish between those cases
by the values of the jack kcontrols (e.g. PulseAudio already can).
next prev parent reply other threads:[~2020-08-22 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 23:32 [PATCH 1/2] ucm: Add JackSwitch definition Curtis Malainey
2020-08-20 23:32 ` [PATCH 2/2] ucm: add DmaPeriodMicrosecs Curtis Malainey
2020-08-22 13:48 ` Alper Nebi Yasak [this message]
2020-08-22 17:07 ` [PATCH 1/2] ucm: Add JackSwitch definition Curtis Malainey
2020-08-22 18:33 ` Alper Nebi Yasak
2020-08-22 20:28 ` Curtis Malainey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98a8a77-7652-1995-27ba-eb7b6d30202a@gmail.com \
--to=alpernebiyasak@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=cujomalainey@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox