From: Randy Dunlap <rdunlap@infradead.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Cheng-Yi Chiang <cychiang@chromium.org>,
linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, ncrews@chromium.org,
bleung@chromium.org, dgreid@chromium.org, tzungbi@chromium.org,
Rohit kumar <rohitkr@codeaurora.org>
Subject: Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845
Date: Mon, 25 Feb 2019 08:29:00 -0800 [thread overview]
Message-ID: <b9b11c13-260f-444c-1b82-993f1bc9ea0f@infradead.org> (raw)
In-Reply-To: <82fe83ba-b967-66ee-1299-1cd98072089a@collabora.com>
On 2/25/19 6:37 AM, Enric Balletbo i Serra wrote:
> Hi,
>
> On 25/2/19 14:54, Cheng-Yi Chiang wrote:
>> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
>> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
>> warning.
>>
>> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
>> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Thanks,
> Enric
Works for me. Thanks.
Tested-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>> sound/soc/qcom/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
>> index 8f206cb4fcc0..75ceb04d8bf0 100644
>> --- a/sound/soc/qcom/Kconfig
>> +++ b/sound/soc/qcom/Kconfig
>> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996
>>
>> config SND_SOC_SDM845
>> tristate "SoC Machine driver for SDM845 boards"
>> - depends on QCOM_APR
>> + depends on QCOM_APR && MFD_CROS_EC
>> select SND_SOC_QDSP6
>> select SND_SOC_QCOM_COMMON
>> select SND_SOC_RT5663
>>
--
~Randy
next prev parent reply other threads:[~2019-02-25 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 13:54 [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845 Cheng-Yi Chiang
2019-02-25 14:37 ` Enric Balletbo i Serra
2019-02-25 16:29 ` Randy Dunlap [this message]
2019-02-26 12:06 ` Applied "ASoC: qcom: Kconfig: fix dependency for sdm845" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b11c13-260f-444c-1b82-993f1bc9ea0f@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=dgreid@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=rohitkr@codeaurora.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).