From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845 Date: Mon, 25 Feb 2019 08:29:00 -0800 Message-ID: References: <20190225135405.108052-1-cychiang@chromium.org> <82fe83ba-b967-66ee-1299-1cd98072089a@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <82fe83ba-b967-66ee-1299-1cd98072089a@collabora.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Enric Balletbo i Serra , Cheng-Yi Chiang , linux-kernel@vger.kernel.org Cc: Mark Brown , alsa-devel@alsa-project.org, ncrews@chromium.org, bleung@chromium.org, dgreid@chromium.org, tzungbi@chromium.org, Rohit kumar List-Id: alsa-devel@alsa-project.org On 2/25/19 6:37 AM, Enric Balletbo i Serra wrote: > Hi, > > On 25/2/19 14:54, Cheng-Yi Chiang wrote: >> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC. >> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies >> warning. >> >> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845) > > Reported-by: Randy Dunlap > >> Signed-off-by: Cheng-Yi Chiang > > Tested-by: Enric Balletbo i Serra > > Thanks, > Enric Works for me. Thanks. Tested-by: Randy Dunlap >> --- >> sound/soc/qcom/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig >> index 8f206cb4fcc0..75ceb04d8bf0 100644 >> --- a/sound/soc/qcom/Kconfig >> +++ b/sound/soc/qcom/Kconfig >> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996 >> >> config SND_SOC_SDM845 >> tristate "SoC Machine driver for SDM845 boards" >> - depends on QCOM_APR >> + depends on QCOM_APR && MFD_CROS_EC >> select SND_SOC_QDSP6 >> select SND_SOC_QCOM_COMMON >> select SND_SOC_RT5663 >> -- ~Randy