From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE764C4332F for ; Tue, 18 Oct 2022 13:50:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72A079CFF; Tue, 18 Oct 2022 15:49:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72A079CFF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666101049; bh=BruUzXTcD0ZSIrLJbGsUpz4KVW2XzzPlCeBQgCkPsEU=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s0r05IK2V0YTYsbAjI5X64lcRW7xr8I14UNtYEf8T2o8YX6Vao+SebS4F66VIMdhG NrqTDfl1GbrnPuw7HiJzbHxaA+qWUPEaYDosSDJ88A25fbsBWS1b/ezMcqDgTabAWD +OP0sU9qOuI7vgr/OUgtn+tvv71MahJS05VBtPZY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F3A98F800E5; Tue, 18 Oct 2022 15:49:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0F9E6F8024C; Tue, 18 Oct 2022 15:49:56 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 532C7F800AB for ; Tue, 18 Oct 2022 15:49:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 532C7F800AB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L97oGSxI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666100994; x=1697636994; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=BruUzXTcD0ZSIrLJbGsUpz4KVW2XzzPlCeBQgCkPsEU=; b=L97oGSxIZc53nZxG804PUdGylppzo2feqtijUbBP1ARUN4b2ZilTWDLD Fcx06AkgWq2qi3HnjAdZrvpri5KrsHv2j6qgrgBF9vzf6sVd9ecpDNYlV lhtIrpTPQp1sIPE/kdLOpD/H7lfBTltw+F3adPJ4X5CUCYQ0reH0tDa2N EwNlxeq4n1tmkd95VGbd2v5FfvBcB0qsXFotcVTxNlNgZp32bC4MCnJ82 YMjB1ZBA8KQjQHkqBWNDO++uT+Q8sTeV2P0qdlxVroankCpsinDVW7wo/ jCsnNGPINXq+hS5xG3IZDoCUr5lVAyuxsAR3BV+7z+A7oohz11M13nhmM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="285829544" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="285829544" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 06:49:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="606545929" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="606545929" Received: from mariaca1-mobl.ger.corp.intel.com (HELO [10.252.27.127]) ([10.252.27.127]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 06:49:48 -0700 Message-ID: Date: Tue, 18 Oct 2022 16:49:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.3.3 Subject: Re: [PATCH 12/19] ASoC: SOF: Intel: Set the default firmware library path for IPC4 Content-Language: en-US To: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= , lgirdwood@gmail.com, broonie@kernel.org References: <20221018120916.19820-1-peter.ujfalusi@linux.intel.com> <20221018120916.19820-13-peter.ujfalusi@linux.intel.com> <4e501a9d-45bb-0ef0-6900-a61af5d4bae0@linux.intel.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= In-Reply-To: <4e501a9d-45bb-0ef0-6900-a61af5d4bae0@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Cezary Rojewski , kai.vehmanen@linux.intel.com, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, chao.song@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 18/10/2022 15:38, Amadeusz Sławiński wrote: >> @@ -174,6 +189,9 @@ static const struct sof_dev_desc rpls_desc = { >>           [SOF_IPC] = "intel/sof", >>           [SOF_INTEL_IPC4] = "intel/avs/rpl-s", >>       }, >> +    .default_lib_path = { >> +        [SOF_INTEL_IPC4] = "intel/avs-lib/rpl-s", >> +    }, >>       .default_tplg_path = { >>           [SOF_IPC] = "intel/sof-tplg", >>           [SOF_INTEL_IPC4] = "intel/avs-tplg", >> @@ -202,6 +220,9 @@ static const struct sof_dev_desc rpl_desc = { >>           [SOF_IPC] = "intel/sof", >>           [SOF_INTEL_IPC4] = "intel/avs/rpl", >>       }, >> +    .default_lib_path = { >> +        [SOF_INTEL_IPC4] = "intel/avs-lib/rpl", >> +    }, >>       .default_tplg_path = { >>           [SOF_IPC] = "intel/sof-tplg", >>           [SOF_INTEL_IPC4] = "intel/avs-tplg", > > > I'm not sure that I understand the rationale here, can't libraries be > kept in the same directory as FW, as far as I know they are version > locked to FW anyway. During the internal review we arrived to this setup, to keep the libraries separate from the basefw binary. One of the reason is that SOF project is not likely not going to release external libraries, they are mostly vendor/product locked. To make the life easier for the vendors (and distributions, packagers) we concluded that it is better to keep them separate. The option is there to specify custom path as well in case it is needed. > In avs driver when we decided on intel/avs/platform > path we planned to keep FW related libaries there... My initial approach was this as well, but after a long debate it got revised. > Also adding Czarek to CC. -- Péter