From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
support.opensource@diasemi.com
Cc: Liam Girdwood <lgirdwood@gmail.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Subject: Re: ASoC: da7218: Use common error handling code in da7218_of_to_pdata()
Date: Fri, 24 Nov 2017 13:50:21 +0100 [thread overview]
Message-ID: <badb0c28-818b-2c71-e4f2-088e6ca0fb6f@users.sourceforge.net> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1B11E5@SW-EX-MBX01.diasemi.com>
>> Add a jump target so that a bit of exception handling can be better reused
>> in an if branch of this function.
…
> Hmm. Doesn't really gain an awful lot this.
I show just another small change possibility.
> Would understand if there were multiple return paths,
> but in that case I'd have implemented something like this anyway.
Where?
Can the suggested software refactoring become useful also for this
function implementation?
> Also your patch description isn't really correct.
Which wording would you find more appropriate?
> You're re-using code from the sunny day scenario to handle an exception.
Can this detail be better?
Regards,
Markus
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-11-24 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 20:03 [PATCH 0/3] ASoC: da7218: Adjustments for two function implementations SF Markus Elfring
2017-11-23 20:04 ` [PATCH 1/3] ASoC: da7218: Delete two error messages for a failed memory allocation in da7218_of_to_pdata() SF Markus Elfring
2017-11-24 11:44 ` Adam Thomson
2017-11-27 18:54 ` Applied "ASoC: da7218: Delete two error messages for a failed memory allocation in da7218_of_to_pdata()" to the asoc tree Mark Brown
2017-11-23 20:06 ` [PATCH 2/3] ASoC: da7218: Use common error handling code in da7218_of_to_pdata() SF Markus Elfring
2017-11-24 12:03 ` Adam Thomson
2017-11-24 12:50 ` SF Markus Elfring [this message]
2017-11-24 12:55 ` Mark Brown
2017-11-24 13:50 ` SF Markus Elfring
2017-11-23 20:07 ` [PATCH 3/3] ASoC: da7218: Improve a size determination in da7218_i2c_probe() SF Markus Elfring
2017-11-24 11:50 ` Adam Thomson
2017-11-27 18:53 ` Applied "ASoC: da7218: Improve a size determination in da7218_i2c_probe()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=badb0c28-818b-2c71-e4f2-088e6ca0fb6f@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).