From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, Jerome Anand <jerome.anand@intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
rakesh.a.ughreja@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [alsa-devel] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT
Date: Fri, 20 Jan 2017 10:45:53 -0600 [thread overview]
Message-ID: <bbe4ac32-db96-c554-f578-56b34fe6be9e@linux.intel.com> (raw)
In-Reply-To: <s5ho9z2q8xf.wl-tiwai@suse.de>
On 1/20/17 5:15 AM, Takashi Iwai wrote:
> On Fri, 20 Jan 2017 23:22:31 +0100,
> Jerome Anand wrote:
>>
>> + had_ops_v1 = had_ops_v1; /* unused */
>
> Until now I didn't realize that the whole v1 stuff is never used in
> the current patchset. Will it be ever used in future? If not, can't
> we clean it up? It's a bunch of codes, including the messy union
> definitions. If there is no v3 or whatever, we can even get rid of
> the whole indirect calls.
>
> And if v1 (and the indirect ops calls) should be kept, actually what
> is the difference between v1 and v2, why both implementations do
> exist? Please elaborate in comments.
v1 refers to Medfield/Clovertrail, v2 to Baytrail/CHT. The differences
are minor and centered on different register definitions or additional
features/bug corrections. We left the v1 code in so far but we could
probably remove it since it's not tested anyway. The question is if we
remove this v1 code and indirect calls now or later, I was planning to
add DP audio support and making more changes would make the integration
more difficult.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-20 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 22:22 [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Jerome Anand
2017-01-20 22:22 ` [PATCH v4 1/5] drm/i915: setup bridge for HDMI LPE audio driver Jerome Anand
2017-01-23 10:54 ` Jani Nikula
2017-01-24 8:21 ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 2/5] drm/i915: Add support for audio driver notifications Jerome Anand
2017-01-23 10:57 ` Jani Nikula
2017-01-23 16:32 ` Pierre-Louis Bossart
2017-01-24 7:00 ` Jani Nikula
2017-01-24 8:42 ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T Jerome Anand
2017-01-20 22:22 ` [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT Jerome Anand
2017-01-20 11:15 ` Takashi Iwai
2017-01-20 16:45 ` Pierre-Louis Bossart [this message]
2017-01-20 19:09 ` [alsa-devel] " Takashi Iwai
2017-01-20 22:22 ` [PATCH v4 5/5] ALSA: x86: hdmi: continue playback even when display resolution changes Jerome Anand
2017-01-23 10:18 ` [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe4ac32-db96-c554-f578-56b34fe6be9e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jerome.anand@intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).