From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A338AC4360C for ; Thu, 10 Oct 2019 15:41:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 227F32064A for ; Thu, 10 Oct 2019 15:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rieRcwGX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 227F32064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6C09915E0; Thu, 10 Oct 2019 17:40:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6C09915E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570722059; bh=sWGTjFtJ2BMTsn88WNfKU4ZqmGloInpmpArLnQw1kOg=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rieRcwGX8Pukm8/ubNCBspn96jGtE6EQzc2Jfnox5L3VYSRiY/RlKI3j8gseB5hhO hVcUWcVlegX+a5xPftWZN8SGYo7FkiiSxNif0rupYDgk4+RFVB1h4BuARqVb+uE6am bze2dIadvHZEWFmu7UPyWY1b4Ittb6QgZqT5z18M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1F38DF804CA; Thu, 10 Oct 2019 17:39:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7D9B5F804CB; Thu, 10 Oct 2019 17:39:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 53DBEF802BC for ; Thu, 10 Oct 2019 17:39:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 53DBEF802BC X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 08:39:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,280,1566889200"; d="scan'208";a="369124825" Received: from aandraox-mobl1.amr.corp.intel.com (HELO [10.254.98.68]) ([10.254.98.68]) by orsmga005.jf.intel.com with ESMTP; 10 Oct 2019 08:39:47 -0700 To: Kuninori Morimoto , Mark Brown References: <87sgo2ilso.wl-kuninori.morimoto.gx@renesas.com> <87ftk2ilqz.wl-kuninori.morimoto.gx@renesas.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 10 Oct 2019 10:09:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87ftk2ilqz.wl-kuninori.morimoto.gx@renesas.com> Content-Language: en-US Cc: Linux-ALSA Subject: Re: [alsa-devel] [PATCH 09/21] ASoC: soc-core: remove unneeded snd_soc_tplg_component_remove() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/8/19 11:30 PM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > snd_soc_tplg_component_remove() is topology related cleanup function. > The driver which added topology needed cleanup it, not by soc-core. > Only topology user skl-pcm is calling it, there is no effect by > this patch. the SOF driver also calls snd_soc_tplg_component_remove(), so not sure what you meant by the comment? > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/soc-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 283ac63..fa837c0 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -2870,8 +2870,6 @@ static int __snd_soc_unregister_component(struct device *dev) > if (dev != component->dev) > continue; > > - snd_soc_tplg_component_remove(component, > - SND_SOC_TPLG_INDEX_ALL); > snd_soc_component_del_unlocked(component); > found = 1; > break; > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel