From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 4/5] ASoC: qcom: q6asm-dai: Constify static struct snd_compress_ops
Date: Fri, 28 May 2021 09:37:11 +0100 [thread overview]
Message-ID: <bd8348e2-7af9-c868-50d0-e359a6a9fb52@linaro.org> (raw)
In-Reply-To: <20210526231013.46530-5-rikard.falkeborn@gmail.com>
On 27/05/2021 00:10, Rikard Falkeborn wrote:
> The snd_compress_ops structs are only stored in the compress_ops field
> of a snd_soc_component_driver struct, so make it const to allow the
> compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
> index 9766725c2916..5ff56a735419 100644
> --- a/sound/soc/qcom/qdsp6/q6asm-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
> @@ -1169,7 +1169,7 @@ static int q6asm_dai_compr_get_codec_caps(struct snd_soc_component *component,
> return 0;
> }
>
> -static struct snd_compress_ops q6asm_dai_compress_ops = {
> +static const struct snd_compress_ops q6asm_dai_compress_ops = {
> .open = q6asm_dai_compr_open,
> .free = q6asm_dai_compr_free,
> .set_params = q6asm_dai_compr_set_params,
>
next prev parent reply other threads:[~2021-05-28 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 23:10 [PATCH 0/5] ASoC: Constify snd_compress_ops Rikard Falkeborn
2021-05-26 23:10 ` [PATCH 1/5] ASoC: cs47125: Constify static struct snd_compress_ops Rikard Falkeborn
2021-05-26 23:10 ` [PATCH 2/5] ASoC: wm5102: " Rikard Falkeborn
2021-05-26 23:10 ` [PATCH 3/5] ASoC: wm5110: " Rikard Falkeborn
2021-05-26 23:10 ` [PATCH 4/5] ASoC: qcom: q6asm-dai: " Rikard Falkeborn
2021-05-28 8:37 ` Srinivas Kandagatla [this message]
2021-05-26 23:10 ` [PATCH 5/5] ASoC: SOF: Intel: Constify sof_probe_compressed_ops Rikard Falkeborn
2021-06-01 17:38 ` [PATCH 0/5] ASoC: Constify snd_compress_ops Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8348e2-7af9-c868-50d0-e359a6a9fb52@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).