From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8F82C00144 for ; Fri, 29 Jul 2022 14:13:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2C46215C3; Fri, 29 Jul 2022 16:12:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2C46215C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1659104006; bh=pYLu+/XtQC5jDjQKiAKoXPu334NKExW5okhxadAJE0c=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kKlnypA3E+a2tCbdZ0+FnJgIEl7OGBPSWHZ6VvnMiv+Nynoip0Oey7C0X0fOhzliU Asd+sBlWFTvdF0ZDzreqDUzi2p3YV6n3zcwvHvDFqAACMlaxOj3WQNDCRjV1ZTus6a E83Un3l+Ghfl+xT2lYaxJZQ6hBezPhFi1HEkRFz4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C6A66F80430; Fri, 29 Jul 2022 16:12:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D327BF8049C; Fri, 29 Jul 2022 16:12:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90012F800BD for ; Fri, 29 Jul 2022 16:12:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90012F800BD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GIa9EHuj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659103952; x=1690639952; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pYLu+/XtQC5jDjQKiAKoXPu334NKExW5okhxadAJE0c=; b=GIa9EHujrBxMSyHGElbEwmM3/QniFwiu3qJpXz474nrWCU2pEjWgnsjy X8aUKatyPb76g+ki7hC4djUlV2f/g15K2SZW4z1o01jiJFVMxW5q5QnkS nWQ0eoV8OqndMsWujml8fFAwFcQPMDyW1sIab8+6z4uyOE8Z/zrrhZO6T cv/A4Nz/ofRzBwPkmcQ3HOExfoe+oE9UFPKWt4YF2OgeLdIbOlWjEd7vn Hg0S+Ys+fYF81Dm4KejhkBf/rEiPQj9Dp/8XQjj+x8m1p9Bw8SFFqjxtv 7Y8h7PvWe4cK7A3T3h6CUGzgmQJOFULRTka+vPXiM5fEQ6ELkwkfQEoND g==; X-IronPort-AV: E=McAfee;i="6400,9594,10423"; a="268537496" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="268537496" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 07:12:18 -0700 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="660249430" Received: from kaholo-mobl.amr.corp.intel.com (HELO [10.212.97.86]) ([10.212.97.86]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 07:12:17 -0700 Message-ID: Date: Fri, 29 Jul 2022 09:12:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH 3/5] soundwire: sysfs: have the driver core handle the creation of the device groups Content-Language: en-US To: Greg Kroah-Hartman , alsa-devel@alsa-project.org References: <20220729135041.2285908-1-gregkh@linuxfoundation.org> <20220729135041.2285908-3-gregkh@linuxfoundation.org> From: Pierre-Louis Bossart In-Reply-To: <20220729135041.2285908-3-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Sanyog Kale , Vinod Koul , Bard Liao , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > index 893296f3fe39..81c77e6ddbad 100644 > --- a/drivers/soundwire/bus_type.c > +++ b/drivers/soundwire/bus_type.c > @@ -193,6 +193,7 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner) > > drv->driver.owner = owner; > drv->driver.probe = sdw_drv_probe; > + drv->driver.dev_groups = sdw_attr_groups; > > if (drv->remove) > drv->driver.remove = sdw_drv_remove; Minor rebase issue: this version of the bus_type.c code is no longer up-to-date, this patch creates a conflict with "soundwire: bus_type: fix remove and shutdown support" merged by Vinod - should be in your char-misc tree as well for 5.20. ++<<<<<<< HEAD + drv->driver.remove = sdw_drv_remove; + drv->driver.shutdown = sdw_drv_shutdown; ++======= + drv->driver.dev_groups = sdw_attr_groups; + + if (drv->remove) + drv->driver.remove = sdw_drv_remove; + + if (drv->shutdown) + drv->driver.shutdown = sdw_drv_shutdown; ++>>>>>>> soundwire: sysfs: have the driver core handle the creation of the device groups Fixing it locally and testing.