From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09499C433E3 for ; Thu, 30 Jul 2020 15:46:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88F7B20838 for ; Thu, 30 Jul 2020 15:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="PoG8A87G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88F7B20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 14FCB17AA; Thu, 30 Jul 2020 17:45:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 14FCB17AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596123959; bh=HsniolWYhJetipdmNlMOUOtzjd8cNUTXOI2D7ebve44=; h=Subject:From:To:References:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PoG8A87GMXSIO1R8zYp0YmPtN/2/ehNkO85v0UbA1FmzLOOW+4PBdscP8J4+kK+9y ALaXqxbdSJo13GlfgerJ9I5KksEdmeaFyxcr6gvrcRoeXgpZ8PaFuWEQbgXsx5tgkK GWlHu/6lcCmdejAVP5OqpRsjsOpsKNzDwEunajC0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A4B09F800C9; Thu, 30 Jul 2020 17:45:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 161A2F8021E; Thu, 30 Jul 2020 17:45:07 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2BCCAF800C9 for ; Thu, 30 Jul 2020 17:44:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2BCCAF800C9 IronPort-SDR: Dh+RWpBsVdrcR+9HNGuUDUBoaSsX8vK57KUE6aBr5W/GV8YFh+03VCzlpr8g+ooRmg3vU8F4VH xICfcDUYfooA== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="149086110" X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="149086110" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 08:44:53 -0700 IronPort-SDR: BaDDVqq1GqCh5P3//G0SQJkoDZ+wJwOxaBVXR86DpT6KgejRLnM2kmkD5ysie2SG0I1YNg4Dog CTWy6xxIrUcw== X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="465284728" Received: from jrwang2-mobl.amr.corp.intel.com (HELO [10.212.82.25]) ([10.212.82.25]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 08:44:49 -0700 Subject: Re: [PATCH 2/2] ASoC: Intel: Add period size constraint on strago board From: Pierre-Louis Bossart To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <1596020585-11517-1-git-send-email-brent.lu@intel.com> <1596020585-11517-3-git-send-email-brent.lu@intel.com> <4fe97f63-e552-3b2f-803c-53894b196bfd@linux.intel.com> Message-ID: Date: Thu, 30 Jul 2020 10:44:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , "Rojewski, Cezary" , Kai Vehmanen , Kuninori Morimoto , Jie Yang , Takashi Iwai , "linux-kernel@vger.kernel.org" , Liam Girdwood , Sam McNally , Mark Brown , Ranjani Sridharan , Daniel Stuart , Andy Shevchenko , Yu-Hsuan Hsu , Damian van Soelen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/30/20 10:27 AM, Pierre-Louis Bossart wrote: > > >>> Is this patch required if you've already constrained the period sizes >>> for the >>> platform driver in patch1? >> >> Yes or alsa will select 320 as default period size for it. > > ok, then that's a miss in your patch1. 320 samples is a multiple of 1ms typo: is NOT > for 48kHz rates. I think it was valid only for the 16kHz VoIP paths used > in some versions of Android, but that we don't support in the upstream > code. > > To build on Takashi's answer, the real ask here is to require that the > period be a multiple of 1ms, because that's the fundamental > design/limitation of firmware. It doesn't matter if it's 48, 96, 192, > 240, 480, 960 samples.