From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 11/11] ASoC: topology: Use unload() op directly
Date: Fri, 27 Jan 2023 09:34:50 -0600 [thread overview]
Message-ID: <c14e9cec-ff7b-c229-ce28-fd1d7c99ec0d@linux.intel.com> (raw)
In-Reply-To: <20230127231111.937721-12-amadeuszx.slawinski@linux.intel.com>
On 1/27/23 17:11, Amadeusz Sławiński wrote:
> struct snd_soc_dobj only needs pointer to the unload function, instead
> however, there is pointer to all topology operations. Change code to use
> the function pointer instead of pointer to structure containing all
> operations.
I still don't see what we gain with this change.
what we had was:
sbe->dobj.ops = tplg->ops;
if (dobj->ops && dobj->ops->control_unload)
dobj->ops->control_unload(comp, dobj);
and now we have this:
if (tplg->ops)
sbe->dobj.unload = tplg->ops->control_unload;
if (dobj->unload)
dobj->unload(comp, dobj);
The improvement is far from obvious to me.
Not going to lay on the tracks for this though.
next prev parent reply other threads:[~2023-01-27 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 23:11 [PATCH 00/11] ASoC: topology: Fixes and cleanups Amadeusz Sławiński
2023-01-27 16:27 ` Jaroslav Kysela
2023-01-30 13:08 ` Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 01/11] ASoC: topology: Properly access value coming from topology file Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 02/11] ASoC: topology: Remove unused SOC_TPLG_PASS_PINS constant Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 03/11] ASoC: topology: Fix typo in functions name Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 04/11] ASoC: topology: Fix function name Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 05/11] ASoC: topology: Rename remove_ handlers Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 06/11] ASoC: topology: Remove unnecessary forward declarations Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 07/11] ASoC: topology: Pass correct pointer instead of casting Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 08/11] ASoC: topology: Return an error on complete() failure Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 09/11] ASoC: Topology: Remove unnecessary check for EOF Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 10/11] ASoC: topology: Unify kcontrol removal code Amadeusz Sławiński
2023-01-27 23:11 ` [PATCH 11/11] ASoC: topology: Use unload() op directly Amadeusz Sławiński
2023-01-27 15:34 ` Pierre-Louis Bossart [this message]
2023-01-30 13:28 ` [PATCH 00/11] ASoC: topology: Fixes and cleanups Amadeusz Sławiński
2023-01-30 21:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14e9cec-ff7b-c229-ce28-fd1d7c99ec0d@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox