From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 256ECC0015E for ; Thu, 27 Jul 2023 03:23:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BB126845; Thu, 27 Jul 2023 05:22:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BB126845 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690428200; bh=nPB2w9dSjqlHnzGsCdfKxPajMcJwjwbcBaw3wQ2gZzQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=flIUyKgig/r1OkGESiy8cTViEHIMN+2qf5TirxEdQ5W014Xa/MZe7XzLSs2qgX7W+ Zwij1KxA6RFPF0ceXaM/P8di7NfRUmIP4BNl9BXBs/pCpyOkCq8Uq5mgnZ71axh9pu kKdCy5epMBXS9fc8YeD2qRRZj/wbPJY7OYu7KhXw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id F1AE7F80535; Thu, 27 Jul 2023 05:22:00 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4A7B3F8019B; Thu, 27 Jul 2023 05:22:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36964F8019B; Thu, 27 Jul 2023 05:21:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4FA17F80153 for ; Thu, 27 Jul 2023 05:21:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4FA17F80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JjrrTNc2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690428112; x=1721964112; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nPB2w9dSjqlHnzGsCdfKxPajMcJwjwbcBaw3wQ2gZzQ=; b=JjrrTNc2/1kHHfc17at1ykuruvvmyKMwUe9Aeh698Kh+9UtdRl8UFrA2 +iLxzUMmaU/TdSKR2NGmP/O7ykiQSq5hemlhhEVIHkD8RXFf4hV6mCCEB Xtw6Dc1iDB5lHYdguf/MHo2cqiKySMPbBCiiwnFnKg4dF5YdPQ9yy3xea d0Q7QOU7RG0CgvNuRBDa0RefU3LJPB0QS2tow1kUCjCwuHhBbXFE5NYAF u4XxEMZJ/UaXchYLt2aR7UDJ9SOlumHuWgIT7TxUZD+DeRyWrTYimo0Iq QLJRvhbbQ1xnNsNJ9MQHlUAgzO8dw80JmYBXgbQYjyRZAy/5ZsZk8a8lu Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="353091846" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="353091846" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 20:21:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="900697655" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="900697655" Received: from yungchua-mobl2.ccr.corp.intel.com (HELO [10.92.2.114]) ([10.92.2.114]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 20:21:45 -0700 Message-ID: Date: Thu, 27 Jul 2023 11:21:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI To: "Lu, Brent" , "alsa-devel@alsa-project.org" Cc: "Rojewski, Cezary" , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "Zhi, Yong" , Ajye Huang , "Bhat, Uday M" , Terry Cheong , "Chiang, Mac" , "R, Dharageswari" , Kuninori Morimoto References: <20230720092628.758834-1-brent.lu@intel.com> <20230720092628.758834-2-brent.lu@intel.com> Content-Language: en-US From: "Liao, Bard" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 2OEH22D53J446TT6NH6R6FIVS5ZD4TNW X-Message-ID-Hash: 2OEH22D53J446TT6NH6R6FIVS5ZD4TNW X-MailFrom: yung-chuan.liao@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/27/2023 10:14 AM, Lu, Brent wrote: >> >> max_98390_components[] and max_98390_4spk_components[] are still used >> >> by sof_rt5682.c, we should remove them in the same patch. >> >> Maybe combine the 2 patches together? >> >> > I've got your point but these two patches are doing two things: one is refactor the > code and add a detection feature, the other one is removing the quirk. Not sure if > it's proper to merge them. The point is that if you remove them and they are still used somewhere, you will break the build. i.e. Kernel will not compile if we apply the first patch only. > Regards, > Brent