Re: [RFC v2 1/3] ASoC: core: allow DAI PCM controls bound to PCM device

[Arnaud Pouliquen <arnaud.pouliquen@st.com>]

Hello Vinod

On 11/24/2016 06:14 AM, Takashi Sakamoto wrote:

>> The same problem (same control names IIUC) existis on codec and SoC's, now
>> that both have DSP, we can have DSP "Volume control"...
>>
>> Would this solve that as well..?
> 
> No. It's not the aim of this patchset and out of its scope.
> 
> However, in fact, we should seek good solution for the issue of
> 'conflict of identification information of control element set added by
> ALSA SoC part automatically'.
>
Solution only solves issue for DAIs that are statically linked to a PCM
device on probe,
In you case, link to PCM device is done during runtime through adpcm, right?
Have you an example of a PCM control that you need to link to the PCM
character device?

>>> Application should be able to address the control using the
>>> device field number, according to the PCM character device.
>>> This patch allows to link DAI PCM controls to the PCM device.
>>
>> why is that part required..? Is the problem being solved to address a
>> control uniquely or something else?
It treats a PCM control uniquely,
 what do you have in mind when you say "or something else"?
>>
>>> During DAI_link probe, PCM controls are added after device field is forced
>>> to the PCM device number.
>>>
>>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>>> ---
>>>  include/sound/soc-dai.h |  4 ++++
>>>  sound/soc/soc-core.c    | 37 +++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 41 insertions(+)

Regards,

Arnaud