From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "Takashi Iwai" <tiwai@suse.de>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v2] ALSA: jack: Access input_dev under mutex
Date: Tue, 12 Apr 2022 12:07:29 +0200 [thread overview]
Message-ID: <c36aaba7-55c0-578d-6cb4-87f79b24fbf9@intel.com> (raw)
In-Reply-To: <s5hwnfuab69.wl-tiwai@suse.de>
On 2022-04-12 11:44 AM, Takashi Iwai wrote:
> On Tue, 12 Apr 2022 11:16:28 +0200,
> Amadeusz Sławiński wrote:
>>
>> It is possible when using ASoC that input_dev is unregistered while
>> calling snd_jack_report, which causes NULL pointer dereference.
>> In order to prevent this serialize access to input_dev using mutex lock.
>>
>> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>> ---
>>
>> Changes:
>> v2:
>> - drop mutex in snd_jack_new
>> - add comment that snd_jack_report() should be called in context where
>> it can sleep
>
> Thanks, applied now.
If you would be needing a reviewed-by-tag, you can safely apply my (it's
missing in v2 sent by Amadeo).
For transparency:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Regards,
Czarek
prev parent reply other threads:[~2022-04-12 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:16 [PATCH v2] ALSA: jack: Access input_dev under mutex Amadeusz Sławiński
2022-04-12 9:44 ` Takashi Iwai
2022-04-12 10:07 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36aaba7-55c0-578d-6cb4-87f79b24fbf9@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox