From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE09AC4361B for ; Tue, 15 Dec 2020 17:49:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDD0B22ADC for ; Tue, 15 Dec 2020 17:49:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDD0B22ADC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A8579180A; Tue, 15 Dec 2020 18:48:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A8579180A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1608054573; bh=RR1ue9ttp8+Uhjc1dmKhhzeOgvK+RK5M5YX+Iuw2fp8=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e1fdCbdDnTq4z/i3N63sc5ITEMnX0Gqj+yKcGmxN4pL9jdLUBDgAxzrakaUuO4lup LQw+VqC0kRP8u29cFnl5L2kBowFM2naXSg/Fm8aOn8tEsv+PUWHqJP1E7zSof5pXAh n2xbVlZIuX3ZBUdHUeI0ZnaDfQLzPO8L1tnqSUFk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24249F80259; Tue, 15 Dec 2020 18:48:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1D02EF80278; Tue, 15 Dec 2020 18:48:41 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1098BF80129; Tue, 15 Dec 2020 18:48:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1098BF80129 IronPort-SDR: aoSOMGZFOJ9P1ScI4GU7EPw4lcR9RU351KeOzyxKwj9Xgm0L0dLU+7KuXIlV8PTDITMh9A56Nn Vsf9kO7ZFZ2g== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="193297864" X-IronPort-AV: E=Sophos;i="5.78,422,1599548400"; d="scan'208";a="193297864" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 09:48:28 -0800 IronPort-SDR: KPRDy3Z0durNXaIKJqGF1UmkJg17B+7rjrXgI7ljceyxeP4O7qeQAylB+opfHHJcBEi+8BPJOY lnGs9ObLZaQA== X-IronPort-AV: E=Sophos;i="5.78,422,1599548400"; d="scan'208";a="451291272" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.249.146.31]) ([10.249.146.31]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 09:48:27 -0800 Subject: Re: [Sound-open-firmware] SoF support for 8086:9d71? To: Pierre-Louis Bossart , Kai-Heng Feng References: <9I9CLQ.GP190FSJBRXK3@canonical.com> <47ec2533-584c-d7f3-4489-e3a043e658e1@linux.intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: Date: Tue, 15 Dec 2020 18:48:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <47ec2533-584c-d7f3-4489-e3a043e658e1@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: SOUND , sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/15/2020 6:21 PM, Pierre-Louis Bossart wrote: > > > On 12/14/20 9:54 PM, Kai-Heng Feng wrote: >> >> >> On Mon, Dec 14, 2020 at 13:33, Pierre-Louis Bossart >> wrote: >>> >>>> On more recent kernels legacy HDA stops working for device 8086:9d71: >>>> [   47.211381] snd_hda_intel 0000:00:1f.3: DSP detected with PCI >>>> class/subclass/prog-if info 0x040100 >>>> [   47.211383] snd_hda_intel 0000:00:1f.3: Digital mics found on >>>> Skylake+ platform, using SST driver >>>> >>>> However, only legacy HDA supports it: >>>> 00:1f.3 Multimedia audio controller [0401]: Intel Corporation >>>> Sunrise Point-LP HD Audio [8086:9d71] (rev 21) >>>> .. >>>>      Kernel modules: snd_hda_intel >>>> >>>> Ubuntu kernel doesn't select SND_SOC_INTEL_SKYLAKE, which builds >>>> snd-soc-skl, because based on the Kconfig description SOF should >>>> support it. >>>> >>>> I wonder if SND_SOC_INTEL_SKYLAKE should be select again? >>> >>> SOF does not support Skylake and Kabylake, and only the Up2 board for >>> APL. I am not sure what you mean by 'recent' kernels since this >>> dynamic selection has been in place for a year now? >> >> Ubuntu kernel only changed this in 20.10 release. >> >>> >>> At any rate, to make this work again: >>> >>> 1. You can select SND_SOC_INTEL_SKYLAKE or alternatively to be more >>> accurate: >>> >>> SND_SOC_INTEL_SKL >>> SND_SOC_INTEL_APL >>> SND_SOC_INTEL_KBL >>> >>> There are known issues with Conexant codecs, typically on HP devices, >>> only Realtek codecs are supported. >> >> Right, so we can't really enable this for generic distros like Ubuntu. >> >> Let me think of a more generic solution. > > Re-thinking about this, I actually don't know how this problem occurred: > the tables are conditionally built so you would only select SST if you > had the drivers compiled in. > > see sound/hda/intel-dsp-config.c: > > /* Kabylake-LP */ > #if IS_ENABLED(CONFIG_SND_SOC_INTEL_KBL) >     { >         .flags = FLAG_SST, >         .device = 0x9d71, >         .dmi_table = (const struct dmi_system_id []) { >             { >                 .ident = "Google Chromebooks", >                 .matches = { >                     DMI_MATCH(DMI_SYS_VENDOR, "Google"), >                 } >             }, >             {} >         } >     }, >     { >         .flags = FLAG_SST | FLAG_SST_ONLY_IF_DMIC, >         .device = 0x9d71, >     }, > #endif > > Something's not adding up here. Seems like you can enable CONFIG_SND_SOC_INTEL_KBL (and all other platforms), without enabling CONFIG_SND_SOC_INTEL_SKYLAKE, which enables building of snd_soc_skl module... I would say that there is something wrong with module dependencies in Kconfig :/ Will look at it tomorrow. In the meantime any chance we can get the config which was used, to confirm my suspicion? Thanks, Amadeusz