From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACF7C433DF for ; Wed, 26 Aug 2020 16:58:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E3C2078B for ; Wed, 26 Aug 2020 16:58:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="BMOFPBUo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27E3C2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BD3861773; Wed, 26 Aug 2020 18:57:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BD3861773 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598461103; bh=9kdNjT7jl3PhSasDz0S747fIIh7tdEWFdkunN4hNTOc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BMOFPBUoJsr/nH234V0MeacDIo+l25WdPt6I0uaV/CSnCZlajDln9wiEVTtt7t4l+ 60WOhY3M0RaM4AJjeiJ19c29PM1MFWarfxTBL4xA3p16AkO5QlMZUI8nX0qtNwqhz+ Bn6TP+TzuSe6phelzvisJFvCfsKzMhmChX2/DM4c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5B2D1F8016F; Wed, 26 Aug 2020 18:57:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78A83F801D9; Wed, 26 Aug 2020 18:57:31 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37854F800EB for ; Wed, 26 Aug 2020 18:57:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37854F800EB IronPort-SDR: kVNw6Q+gidZwDDT7HgolJ02fXAKsctMf/s8n0l00NvivKFxvVt0U8B/qfkx1PRXrOQbWdAkqfS TrAlLl44VsEQ== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="157371658" X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="157371658" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 09:57:20 -0700 IronPort-SDR: riyJ8XK6HQxCF87dKaM13QFC5KCh0hRvWCGpTHaRFjfTuS59kns1kMJnj+aqsEJhc364A9fs85 ff4SjXLYIdqw== X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="336884223" Received: from kberke-mobl1.amr.corp.intel.com (HELO [10.209.43.169]) ([10.209.43.169]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 09:57:16 -0700 Subject: Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ To: Vinod Koul References: <20200825171656.75836-1-pierre-louis.bossart@linux.intel.com> <20200825171656.75836-5-pierre-louis.bossart@linux.intel.com> <20200826090542.GZ2639@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Wed, 26 Aug 2020 11:57:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200826090542.GZ2639@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Kai Vehmanen , "Rafael J. Wysocki" , tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> +#include >> +#include >> +#include > > Curious why do you need this header? I'll return the question back to you, since you added this header for regmap-sdw.c: 7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include so I assumed it was needed here as well. >> +MODULE_DESCRIPTION("Regmap SoundWire Module"); > > This is same of sdw module, pls make this one a bit different. yes, fixed.