alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>,
	dmaengine <dmaengine@vger.kernel.org>,
	Jie Yang <yang.jie@linux.intel.com>
Subject: Re: [PATCH v3 4/4] ASoC: Intel: rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM
Date: Mon, 2 Jan 2017 10:05:40 -0600	[thread overview]
Message-ID: <c5228e73-d5cf-e4cd-b78b-24334e1fb5f3@linux.intel.com> (raw)
In-Reply-To: <20170102152017.13938-5-andriy.shevchenko@linux.intel.com>



On 01/02/2017 09:20 AM, Andy Shevchenko wrote:
> Rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM to make it clear that is
> not only about Medfield platform.
Does this change make sense? Medfield was a completely different 
platform and lumping everything under the same Kconfig option doesn't 
seem right to me... Plus we've stopped using 'mid' for years, no one 
would know what it stands for. The only clear architecture feature is 
the presence of the switch matrix that uniquely identifies all platforms 
based on Baytrail, Cherrytrail, Merrifield and Anniedale. 
Medfield/Clovertrail did not expose a switch matrix.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   sound/soc/intel/Kconfig       | 14 +++++++-------
>   sound/soc/intel/Makefile      |  2 +-
>   sound/soc/intel/atom/Makefile |  7 ++++---
>   3 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 7da8b9ceb728..c44da83c71a8 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -2,7 +2,7 @@ config SND_MFLD_MACHINE
>   	tristate "SOC Machine Audio driver for Intel Medfield MID platform"
>   	depends on INTEL_SCU_IPC
>   	select SND_SOC_SN95031
> -	select SND_SST_MFLD_PLATFORM
> +	select SND_SST_MID_PLATFORM
>   	select SND_SST_IPC_PCI
>   	help
>             This adds support for ASoC machine driver for Intel(R) MID Medfield platform
> @@ -10,7 +10,7 @@ config SND_MFLD_MACHINE
>             Say Y if you have such a device.
>             If unsure select "N".
>   
> -config SND_SST_MFLD_PLATFORM
> +config SND_SST_MID_PLATFORM
>   	tristate
>   	select SND_SOC_COMPRESS
>   
> @@ -137,7 +137,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH
>           tristate "ASoC Audio driver for Intel Baytrail and Baytrail-CR with RT5640 codec"
>   	depends on X86 && I2C && ACPI
>   	select SND_SOC_RT5640
> -	select SND_SST_MFLD_PLATFORM
> +	select SND_SST_MID_PLATFORM
>   	select SND_SST_IPC_ACPI
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>   	help
> @@ -150,7 +150,7 @@ config SND_SOC_INTEL_BYTCR_RT5651_MACH
>           tristate "ASoC Audio driver for Intel Baytrail and Baytrail-CR with RT5651 codec"
>   	depends on X86 && I2C && ACPI
>   	select SND_SOC_RT5651
> -	select SND_SST_MFLD_PLATFORM
> +	select SND_SST_MID_PLATFORM
>   	select SND_SST_IPC_ACPI
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>   	help
> @@ -163,7 +163,7 @@ config SND_SOC_INTEL_CHT_BSW_RT5672_MACH
>           tristate "ASoC Audio driver for Intel Cherrytrail & Braswell with RT5672 codec"
>           depends on X86_INTEL_LPSS && I2C && ACPI
>           select SND_SOC_RT5670
> -        select SND_SST_MFLD_PLATFORM
> +        select SND_SST_MID_PLATFORM
>           select SND_SST_IPC_ACPI
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>           help
> @@ -176,7 +176,7 @@ config SND_SOC_INTEL_CHT_BSW_RT5645_MACH
>   	tristate "ASoC Audio driver for Intel Cherrytrail & Braswell with RT5645/5650 codec"
>   	depends on X86_INTEL_LPSS && I2C && ACPI
>   	select SND_SOC_RT5645
> -	select SND_SST_MFLD_PLATFORM
> +	select SND_SST_MID_PLATFORM
>   	select SND_SST_IPC_ACPI
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>   	help
> @@ -189,7 +189,7 @@ config SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH
>   	depends on X86_INTEL_LPSS && I2C && ACPI
>   	select SND_SOC_MAX98090
>   	select SND_SOC_TS3A227E
> -	select SND_SST_MFLD_PLATFORM
> +	select SND_SST_MID_PLATFORM
>   	select SND_SST_IPC_ACPI
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>   	help
> diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
> index 2b45435e6245..58578f8a3b45 100644
> --- a/sound/soc/intel/Makefile
> +++ b/sound/soc/intel/Makefile
> @@ -4,7 +4,7 @@ obj-$(CONFIG_SND_SOC_INTEL_SST) += common/
>   # Platform Support
>   obj-$(CONFIG_SND_SOC_INTEL_HASWELL) += haswell/
>   obj-$(CONFIG_SND_SOC_INTEL_BAYTRAIL) += baytrail/
> -obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += atom/
> +obj-$(CONFIG_SND_SST_MID_PLATFORM) += atom/
>   obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/
>   
>   # Machine support
> diff --git a/sound/soc/intel/atom/Makefile b/sound/soc/intel/atom/Makefile
> index ce8074fa6d66..a1f2f1ba158d 100644
> --- a/sound/soc/intel/atom/Makefile
> +++ b/sound/soc/intel/atom/Makefile
> @@ -1,7 +1,8 @@
> -snd-soc-sst-mfld-platform-objs := sst-mfld-platform-pcm.o \
> -	        sst-mfld-platform-compress.o sst-atom-controls.o
> +snd-soc-sst-mid-platform-objs := sst-mfld-platform-pcm.o \
> +				 sst-mfld-platform-compress.o \
> +				 sst-atom-controls.o
>   
> -obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += snd-soc-sst-mfld-platform.o
> +obj-$(CONFIG_SND_SST_MID_PLATFORM) += snd-soc-sst-mid-platform.o
>   
>   # DSP driver
>   obj-$(CONFIG_SND_SST_IPC) += sst/

  reply	other threads:[~2017-01-02 16:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 15:20 [PATCH v3 0/4] ASoC: Intel: clean up Kconfig Andy Shevchenko
2017-01-02 15:20 ` [PATCH v3 1/4] ASoC: Intel: select DW_DMAC_CORE since it's mandatory Andy Shevchenko
2017-01-03  2:00   ` Keyon Jie
2017-01-02 15:20 ` [PATCH v3 2/4] ASoC: Intel: remove redundant select SND_SOC_INTEL_SST Andy Shevchenko
2017-01-17 18:45   ` Applied "ASoC: Intel: remove redundant select SND_SOC_INTEL_SST" to the asoc tree Mark Brown
2017-01-02 15:20 ` [PATCH v3 3/4] ASoC: Intel: remove ignored dependencies Andy Shevchenko
2017-01-17 18:45   ` Applied "ASoC: Intel: remove ignored dependencies" to the asoc tree Mark Brown
2017-01-02 15:20 ` [PATCH v3 4/4] ASoC: Intel: rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM Andy Shevchenko
2017-01-02 16:05   ` Pierre-Louis Bossart [this message]
2017-01-03  3:38     ` Vinod Koul
2017-01-03 14:18       ` Pierre-Louis Bossart
2017-01-04 10:44         ` Andy Shevchenko
2017-01-04 16:58           ` Pierre-Louis Bossart
2017-01-05  3:53             ` Vinod Koul
2017-01-05  8:41               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5228e73-d5cf-e4cd-b78b-24334e1fb5f3@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).