From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189DBC55189 for ; Wed, 22 Apr 2020 11:10:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E6920774 for ; Wed, 22 Apr 2020 11:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kKEc0D0+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87E6920774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA4B2168B; Wed, 22 Apr 2020 13:09:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA4B2168B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587553843; bh=cXQIrcxk7DwRNMc7uf7/IchJwrBTPbpiVuu4mc7xxS0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kKEc0D0+E75+aN9auOMqC5v+Mkh32w3nPl03dL0mwm5hzYtmkzOEuugLY3F0wHwTE Qih/Erjq1xwvLO4xwTkHiID4mSQrClxt+w3i5dNiV5Opur2TyUiN0zf678no1RONbh tPmJHbNQJl3y8SjX8K3cx1fdCAFg0AM5FcYw/PBk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 34EF8F80142; Wed, 22 Apr 2020 13:09:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A25DF800F2; Wed, 22 Apr 2020 13:09:50 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9A347F800F2 for ; Wed, 22 Apr 2020 13:09:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9A347F800F2 IronPort-SDR: xIeZdoYkaUhHzju1wDh2ty86eMt4sJzrLCXrbShaj1ln8l2tzni5HSI231O1rl8IFMpT53WG84 SvCW81zqpCKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 04:09:37 -0700 IronPort-SDR: C8gBEMh74DJeDpXbU7qrvhRVlQBYlnTsVVaUFYIoZGnnyDwZ/+ZG2r1FEdHQ7lc4xpWXXlpWMu NJKRArDDUW6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,414,1580803200"; d="scan'208";a="457108260" Received: from ajavier-mobl1.amr.corp.intel.com (HELO [10.255.68.153]) ([10.255.68.153]) by fmsmga006.fm.intel.com with ESMTP; 22 Apr 2020 04:09:36 -0700 Subject: Re: [RFC PATCH 13/16] clk: hifiberry-dacpro: add "sclk" lookup To: Stephen Boyd , alsa-devel@alsa-project.org References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-14-pierre-louis.bossart@linux.intel.com> <158754810745.132238.7647643247125302962@swboyd.mtv.corp.google.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 22 Apr 2020 04:51:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <158754810745.132238.7647643247125302962@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Rob Herring , linux-gpio@vger.kernel.org, tiwai@suse.de, Linus Walleij , Daniel Matuschek , Hui Wang , Matthias Reichl , broonie@kernel.org, Bartosz Golaszewski , Andy Shevchenko , Michael Turquette , linux-clk@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> + proclk->sclk_lookup = clkdev_hw_create(&proclk->hw, "sclk", NULL); >> + if (!proclk->sclk_lookup) { >> +#ifndef CONFIG_ACPI > > Is it to save code space? Otherwise the ifdefs are pretty ugly and I'd > prefer we just call of_clk APIs and rely on the inline stubs when > CONFIG_OF isn't enabled to be optimized out. CONFIG_OF was added as a dependency (see patch 10/16) so that we can use the 'compatible' string to probe w/ the PRP0001 device. I must admit I don't know what these functions do so I just filtered them out in the ACPI case. >> + of_clk_del_provider(dev->of_node); >> +#endif >> + return -ENOMEM; >> + } >> +