From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: Skylake: Set sample_type in base config Date: Wed, 27 Feb 2019 08:45:37 -0600 Message-ID: References: <1551250158-27591-1-git-send-email-jenny.tc@intel.corp-partner.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B8CF3F89699 for ; Wed, 27 Feb 2019 15:45:41 +0100 (CET) In-Reply-To: <1551250158-27591-1-git-send-email-jenny.tc@intel.corp-partner.google.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Jenny TC , alsa-devel@alsa-project.org, Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rakesh Ughreja , Sriram Periyasamy , Abhijeet Kumar , Sanyog Kale Cc: N Harshapriya , M Naveen , M R Sathya Prakash , jenny.tc@intel.com, Nujella Sathyanarayana List-Id: alsa-devel@alsa-project.org On 2/27/19 12:49 AM, Jenny TC wrote: > From: Jenny TC > > sample_type defined in topology configuration is not getting reflected > in the dsp param. This patch sets sample_type in base config so that > the sample type defined in the topology is reflected int eh dsp params. > This issues was uncovered while debugging the S24_LE format which > require the MSB byte in 32 bit word to be skipped. Setting sample_type > to 1 helps to fix this. skl_set_base_module_format() is called from a variety of places, so am I correct in stating that S24_LE never worked with this driver? If so, the patch should really be titled "ASoC: Intel: Skylake: enable S24_LE format support" Also your commit message is confusing in the last sentence. What do you mean by "Setting sample_type to " when you only use what's provided by the topology? > > Signed-off-by: Jenny TC > --- > sound/soc/intel/skylake/skl-messages.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c > index b0e6fb9..9260e9a 100644 > --- a/sound/soc/intel/skylake/skl-messages.c > +++ b/sound/soc/intel/skylake/skl-messages.c > @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx, > base_cfg->audio_fmt.bit_depth = format->bit_depth; > base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth; > base_cfg->audio_fmt.ch_cfg = format->ch_cfg; > + base_cfg->audio_fmt.sample_type = format->sample_type; > > dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n", > format->bit_depth, format->valid_bit_depth,