From: mengdong.lin@linux.intel.com
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Mengdong Lin <mengdong.lin@linux.intel.com>,
tiwai@suse.de, mengdong.lin@intel.com, vinod.koul@intel.com,
rakesh.a.ughreja@intel.com, liam.r.girdwood@intel.com,
hardik.t.shah@intel.com, subhransu.s.prusty@intel.com
Subject: [PATCH v3 1/7] topology: Use the generic pointer to free an element's object
Date: Thu, 7 Apr 2016 15:28:42 +0800 [thread overview]
Message-ID: <c8d960fe4b38966d873f0f3951aff9879208d112.1460013338.git.mengdong.lin@linux.intel.com> (raw)
In-Reply-To: <cover.1460013338.git.mengdong.lin@linux.intel.com>
From: Mengdong Lin <mengdong.lin@linux.intel.com>
The element is a wrapper for different types of objects.So use the
generic pointer 'obj' instead of the type-specific pointer to free
the object.
Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>
diff --git a/src/topology/elem.c b/src/topology/elem.c
index 12d6a72..00f9eea 100644
--- a/src/topology/elem.c
+++ b/src/topology/elem.c
@@ -83,8 +83,8 @@ void tplg_elem_free(struct tplg_elem *elem)
/* free struct snd_tplg_ object,
* the union pointers share the same address
*/
- if (elem->mixer_ctrl)
- free(elem->mixer_ctrl);
+ if (elem->obj)
+ free(elem->obj);
free(elem);
}
--
2.5.0
next prev parent reply other threads:[~2016-04-07 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 7:27 [PATCH v3 0/7] topology: Add support for vendor tuples mengdong.lin
2016-04-07 7:28 ` mengdong.lin [this message]
2016-04-07 7:29 ` [PATCH v3 2/7] topology: Define a free handler for the element mengdong.lin
2016-04-07 7:29 ` [PATCH v3 3/7] topology: Add doc for vendor tuples mengdong.lin
2016-04-07 7:29 ` [PATCH v3 4/7] topology: ABI - Define types " mengdong.lin
2016-04-07 7:29 ` [PATCH v3 5/7] topology: Add support for vendor tokens mengdong.lin
2016-04-07 7:29 ` [PATCH v3 6/7] topology: Add support for parsing vendor tuples mengdong.lin
2016-04-07 7:29 ` [PATCH v3 7/7] topology: Build data objects with tuples mengdong.lin
2016-04-07 9:22 ` [PATCH v3 0/7] topology: Add support for vendor tuples Takashi Iwai
2016-04-07 14:33 ` Lin, Mengdong
2016-04-07 14:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d960fe4b38966d873f0f3951aff9879208d112.1460013338.git.mengdong.lin@linux.intel.com \
--to=mengdong.lin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hardik.t.shah@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).