From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: Intel: Baytrail: Fix implicit fallthrough warning
Date: Wed, 28 Aug 2019 11:45:01 +0200 [thread overview]
Message-ID: <c9156b17-7e48-cf5b-55f8-ff0fad591e8b@intel.com> (raw)
In-Reply-To: <ed82f3b9-92da-dced-2fef-dee92ca67f10@linux.intel.com>
On 2019-08-22 16:08, Pierre-Louis Bossart wrote:
> On 8/22/19 7:01 AM, Cezary Rojewski wrote:
>> Separate _SUSPEND from _PAUSE_PUSH to ensure code is handled correctly
>> while fixing warning reported during compilation.
>>
>> Fixes: b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only
>> when ADSP was in reset")
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> ---
>> sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
>> b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
>> index 9cbc982d46a9..eddb24ab8072 100644
>> --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
>> +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
>> @@ -193,6 +193,8 @@ static int sst_byt_pcm_trigger(struct
>> snd_pcm_substream *substream, int cmd)
>> break;
>> case SNDRV_PCM_TRIGGER_SUSPEND:
>> pdata->restore_stream = false;
>> + sst_byt_stream_pause(byt, pcm_data->stream);
>> + break;
>
> why not just a /* fallthrough */ statement?
>
Just a matter of taste. Sending v2 with update.
>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>> sst_byt_stream_pause(byt, pcm_data->stream);
>> break;
>>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-08-28 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 12:01 [PATCH] ASoC: Intel: Baytrail: Fix implicit fallthrough warning Cezary Rojewski
2019-08-22 14:08 ` Pierre-Louis Bossart
2019-08-28 9:45 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9156b17-7e48-cf5b-55f8-ff0fad591e8b@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox