From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CB6C433E1 for ; Mon, 27 Jul 2020 09:51:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CFDE20672 for ; Mon, 27 Jul 2020 09:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j0XSCYYv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AzbHjDgw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CFDE20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8FE851685; Mon, 27 Jul 2020 11:50:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8FE851685 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595843477; bh=cRfKxsZfvvO/HcSdw/dyWLP0nnOAaayutcDpe8Y1sOM=; h=Subject:To:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j0XSCYYvm52zBSh2FVbOFjuvrMyHjHpos6stHoelBKgRDyUE6S9BZzKYGiadqCDwp /qw2/Gi2V+Sq6qdCEZMzWyeKfNUlnT5rOqtZTmh6MXxOxhVFomlFJILjh/GyMyWKbw 1zWNtjpAqhZS8yWgaaw7KFDtt6ARaEIGTyz44cek= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 31926F80158; Mon, 27 Jul 2020 11:50:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B98B8F80171; Mon, 27 Jul 2020 11:50:25 +0200 (CEST) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3410F8013C for ; Mon, 27 Jul 2020 11:50:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3410F8013C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AzbHjDgw" DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595843415; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: To: Subject: Sender; bh=Kbjy0E1cyBAH7os5xRP4ZFWN/pUN1FsBi0P64wEC5LI=; b=AzbHjDgwidykFL3vYLht95d26Dcxom3KGkmQAOsHQ852Qcy9Iu4hG+y6Uro0/OoR6/+D0zPn c2fP2t+5hariyq7vRva5d3JbTXChMGK55HuMoU5dmoPSIs8zwUtsuyi3BA1coSNIms5ppXkr X1YbbJRdWuu2rW2yK0CRLjgdR+s= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI4ZmE2ZSIsICJhbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5f1ea35549176bd382b44a1b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 27 Jul 2020 09:50:13 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 53C00C433C6; Mon, 27 Jul 2020 09:50:13 +0000 (UTC) Received: from [192.168.0.129] (unknown [183.83.142.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rohitkr) by smtp.codeaurora.org (Postfix) with ESMTPSA id 119ACC433C9; Mon, 27 Jul 2020 09:50:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 119ACC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=rohitkr@codeaurora.org Subject: Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant To: Srinivas Kandagatla , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1595413915-17867-1-git-send-email-rohitkr@codeaurora.org> From: Rohit Kumar Message-ID: Date: Mon, 27 Jul 2020 15:20:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: > > > On 22/07/2020 11:31, Rohit kumar wrote: >> This patch chain add audio support for SC7180 soc by doing the required >> modification in existing common lpass-cpu/lpass-platform driver. >> This also fixes some concurrency issue. >> >> Changes since v3: >>     - Fixed yaml documentation comments and make dt_binding_check >> issues. >>     - Moved general fixes out of sc7180 specific patches as suggested >> by Srinivas. >>     - Update clock-names to make it same as existing platforms. >> >> Ajit Pandey (4): >>    ASoC: qcom: Add common array to initialize soc based core clocks >>    ASoC: qcom: lpass-platform: Replace card->dev with component->dev >>    include: dt-bindings: sound: Add sc7180-lpass bindings header >>    ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio >> >> Rohit kumar (8): >>    ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function >>    ASoC: qcom: lpass-platform: fix memory leak >>    ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers >>    ASoC: qcom: lpass-cpu: fix concurrency issue >>    dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node >>    ASoC: qcom: lpass-cpu: Use platform_get_resource >>    ASoC: qcom: lpass-platform: Use platform_get_irq >>    dt-bindings: sound: lpass-cpu: Move to yaml format > > Thanks Srini for review and testing. Mark, I am planning to repost patch07 onwards to address comments by Rob as there are no comments till patch06 and they are just fixes. > Tested this on Dragon Board 410c! > > Tested-by: Srinivas Kandagatla > > --srini >> >>   .../devicetree/bindings/sound/qcom,lpass-cpu.txt   |  79 -------- >>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  | 185 >> ++++++++++++++++++ >>   include/dt-bindings/sound/sc7180-lpass.h           |  10 + >>   sound/soc/qcom/Kconfig                             |   5 + >>   sound/soc/qcom/Makefile                            |   2 + >>   sound/soc/qcom/lpass-apq8016.c                     |  86 ++++++-- >>   sound/soc/qcom/lpass-cpu.c                         | 204 >> ++++++++++--------- >>   sound/soc/qcom/lpass-ipq806x.c                     |  67 +++++++ >>   sound/soc/qcom/lpass-lpaif-reg.h                   | 157 >> ++++++++------- >>   sound/soc/qcom/lpass-platform.c                    | 155 >> +++++++++++---- >>   sound/soc/qcom/lpass-sc7180.c                      | 216 >> +++++++++++++++++++++ >>   sound/soc/qcom/lpass.h                             |  63 +++++- >>   12 files changed, 930 insertions(+), 299 deletions(-) >>   delete mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>   create mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >>   create mode 100644 include/dt-bindings/sound/sc7180-lpass.h >>   create mode 100644 sound/soc/qcom/lpass-sc7180.c >> -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.