From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035B7C5518A for ; Wed, 22 Apr 2020 12:05:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DA6720784 for ; Wed, 22 Apr 2020 12:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kqd75pc3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DA6720784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1900169B; Wed, 22 Apr 2020 14:04:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1900169B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587557098; bh=yH5sOA1FvPP9ULM8IE8o6fItNjpwIix1STLnoWo1sHE=; h=From:Subject:To:References:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kqd75pc39puFnPOvVPXcS+6wmxBbxH5iervWGgiAXtrc5N0qcMIiJ4JbzCsbVuGri 86MR9Dx+8mJal18qcYFnWztuHN+YvAJ9p64eix6uEN9bu8FOWR9jl6emNTxcWk0qMX ECZ/FaKvYZyd04xVUap56rjp1WxvWiW39411TKZc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 433C3F80108; Wed, 22 Apr 2020 14:04:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1C901F800FF; Wed, 22 Apr 2020 14:04:06 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09667F800F2 for ; Wed, 22 Apr 2020 14:04:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09667F800F2 IronPort-SDR: eLG6AjCzpneP6tPLH2UMT0zVLLEW1nMjekA10oWUC4gD2qKbTnSzRX/RIsoznO/qMNXHtaAB9j k2NUILrEUmQA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 05:03:58 -0700 IronPort-SDR: hERZUvV+5a7uTj7m9y167Mqti8rPuI+F07xBKtGcSLU12L+/4QWtBCrlZuci7F2kEa1stPMzu3 b0efKFHsvHew== X-IronPort-AV: E=Sophos;i="5.72,414,1580803200"; d="scan'208";a="429887138" Received: from mgorski-mobl.ger.corp.intel.com (HELO [10.252.52.93]) ([10.252.52.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 05:03:57 -0700 From: "Gorski, Mateusz" Subject: Re: [PATCH 1/4] ASoC: Intel: Skylake: Change the order of machine device and platform registration To: Pierre-Louis Bossart , alsa-devel@alsa-project.org References: <20200421202519.4008-1-mateusz.gorski@linux.intel.com> <20200421202519.4008-2-mateusz.gorski@linux.intel.com> Message-ID: Date: Wed, 22 Apr 2020 14:03:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Cc: cezary.rojewski@intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > Swap the order of machine device and platform device registration. >> This change ensures that even if the codec enumeration falls late - >> during >> the driver module or topology reload - i2s_dev field is always ready to >> be used. > > Are you sure? > > The platform device will register the DAIs that are used by the > machine driver, don't you have a risk of missing dependencies during > the card registration with this change? > > Put differently, why do this now when the existing code has been > 'working' for a number of years without needing such a change? > This change was tested on multiple platforms (including production laptops) and did not show any issues. Anyway, in patchset v2 the alt_tplg_name creation mechanism was slightly changed and this patch was removed. Thanks for your input, Mateusz