From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Paul Cercueil <paul@crapouillou.net>, broonie@kernel.org
Subject: Re: [PATCH] ASoC: Intel: bytcht_es8316: fix compilation warning and quirk handling
Date: Wed, 10 Apr 2019 12:58:48 -0500 [thread overview]
Message-ID: <cbd7885e-07a0-fadb-b5dd-21e7cdec9b25@linux.intel.com> (raw)
In-Reply-To: <fec99a28-8109-659a-a51e-f1475a015144@redhat.com>
> There is a good reason to use -1 for quirk-override not set.
>
> The user may want to override the quirk variable to actual 0, on
> CHT we default to:
>
> /* Others default to internal-mic-in1-map, mono-speaker */
> quirk = BYT_CHT_ES8316_INTMIC_IN1_MAP |
> BYT_CHT_ES8316_MONO_SPEAKER;
>
> Which is 0x20000, if the user now justs wants to clear the
> BYT_CHT_ES8316_MONO_SPEAKER flag through the override, then the user
> must be able to specify 0 as override.
ok, I accept the argument but then why don't we do the same in other
machine drivers? I could make the same argument for bytcr_rt5640/51, so
we should align all machine drivers using this mechanism.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-04-10 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 16:05 [PATCH] ASoC: Intel: bytcht_es8316: fix compilation warning and quirk handling Pierre-Louis Bossart
2019-04-10 16:16 ` Hans de Goede
2019-04-10 17:58 ` Pierre-Louis Bossart [this message]
2019-04-18 11:57 ` Hans de Goede
2019-04-18 12:57 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd7885e-07a0-fadb-b5dd-21e7cdec9b25@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=paul@crapouillou.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).