From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B34F6C35274 for ; Thu, 21 Dec 2023 08:42:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1E1A7DF0; Thu, 21 Dec 2023 09:42:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1E1A7DF0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1703148143; bh=3cGSBpdNbAx7qxjwiTWbhW7waUUlCZO1OMsVv6u3u4A=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ucMT/+uL89MPhd96oukROu8JPbWLu1od3g/xbzxeTf0iCQDYWMK5AgOvt6YYEDb4e zSBQO2TjmIOk7EZQIkY67SiJZYsecGLJg3xaVqpdwAnFhneDWA9qLAhoHbZ/PUNZwv +/+aHhm3VbpCQw7mg+TFWiqJ7Yh88BWgxtmq61/4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58F86F8057E; Thu, 21 Dec 2023 09:41:51 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BDCFEF80587; Thu, 21 Dec 2023 09:41:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B7F8F80153; Thu, 21 Dec 2023 09:41:45 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2593FF800D2 for ; Thu, 21 Dec 2023 09:41:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2593FF800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=ljones.dev header.i=@ljones.dev header.a=rsa-sha256 header.s=fm3 header.b=YoxynidC; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=ZzaUFC6d Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1C8B75C01C4; Thu, 21 Dec 2023 03:41:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 21 Dec 2023 03:41:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1703148096; x=1703234496; bh=uDYCns7R2c9+ba4N41tqq3RlwSG0Hhskkv8O0oTsnv0=; b= YoxynidCHbY15rnJINRcioZqvc0TbF6Vi+f/gt9wZaNAmDJ7PZmSEeKs/3f3y4+t 4mTHaUA0e2yFRRkVQ/K9T2NHAhmDd/N1LyrOdFW6kayao81YBCajO1ceInt8lM0B iMlxcT/xnHplv0u8QjLSJWfC9AAb0r7zdzAV18zaoGYKxgmd5jT9FjOlg/01iHOB Ac1Y2an9M21ZcyRMIy41bw0sk5wuQyttyUrI/cuczaGy6sM0xoXb6NCUkY/iR8q7 +VVcCnoqN6SSCsLAsiYKulxEtmYkjbqKe9jTH5S7Rk4pMhwY8uLYWp6rNzZtqnyw 6U5Hd0bcwq8F6FPQ92oH4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703148096; x= 1703234496; bh=uDYCns7R2c9+ba4N41tqq3RlwSG0Hhskkv8O0oTsnv0=; b=Z zaUFC6duztSx+Frn4etT3WSzBTqPNPE4aExazCG+lUg/NxSo/oiOBT6gI19p73IR 2srVvr1Ajc6+7ERgAjHHmMKzudwQlznxzTOFggFBmXngEHjRcjGZvCk229UYBzIm 2Xqj5YAy5Gktqd27YgocvdJiYksozuovZozzMopX1z6BeQv/NZBatdHTGa5rzPGa 7Kfxb3Ub1LSqz6J2VhXs0EnCqTS2BN2yT4R+qxNdfaqUD+wxkLH0YYL4f8a0Pa+J oIIzi0ZbmmPwHPrT/CbhErcJFnDKTzra7LmNT/n5j9u1zsO7++BFwLS9gNf1Mfxh 2hTokzPxLVKw4RlhNVJLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddufedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkuffhvfevffgjfhgtgfgfggesthhqredttderjeenucfhrhhomhepnfhu khgvucflohhnvghsuceolhhukhgvsehljhhonhgvshdruggvvheqnecuggftrfgrthhtvg hrnhepkeefffeujeevueejueegleelhedtgedvledukedttdffhfeifeelvdduheefjeei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhukh gvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Dec 2023 03:41:32 -0500 (EST) Message-ID: Subject: Re: [PATCH v1 2/7] ALSA: hda: cs35l41: Support additional ASUS ROG 2023 models From: Luke Jones To: Stefan Binding , Jaroslav Kysela , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Date: Thu, 21 Dec 2023 21:41:26 +1300 In-Reply-To: <20231218151221.388745-3-sbinding@opensource.cirrus.com> References: <20231218151221.388745-1-sbinding@opensource.cirrus.com> <20231218151221.388745-3-sbinding@opensource.cirrus.com> Autocrypt: addr=luke@ljones.dev; prefer-encrypt=mutual; keydata=mQENBGRG7LwBCADC4B1XNMyJpOmtXVhN12glMXTVTV9RxgqunqQt7g+3RAG8kfYcAE+VnCUbcdtjeLRYhVka1zE86VBp0cyXiG9IYNlGZhtBFeik5NdgFt2fBXhDV3fm+91ARLvW7iOxHepyG+jepFf18oI6mPXC7cBzysosEkzdHl0Rm5z9rUoXksVzlT3i76s1AfQL3empFKbKkwSZsMVY/MLzWjPjVloMPqxfwpCex6PHnHfZ37VabsI3CG5Whmo3B+kFvpAYvCZZKYTjGDuFfFEH5Ba6FeY0xNSJYGyvuE8LY1VehipZtEaqnxiNP7kU0t5ZTX7nfDbi9a7uaqqHdPAJDCitJPhTABEBAAG0HEx1a2UgSm9uZXMgPGx1a2VAbGpvbmVzLmRldj6JAVEEEwEIADsWIQRZERbOg6XlNi+ijnEwmht7rUENtAUCZEbsvAIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCRAwmht7rUENtGoxB/wNh2J4t/Scb94yAUNGXje65tuC9ej+XHtfeDCKhQW0WchSDaXpZHLn47b9o+nBaICIaa1WR29viPNAk4Ss7k0lx5w7A/vSYrGcpO69DLWwMhqk+pVn+RPfeuGKwxGhvEjZkWSwIYXtBDfVXM7Paiq6ZOiaYOlFokbvV1s1NfIaxkTdJwuFK14SYfn3CE1XdyUQ2EQ9572yATPwElcaNp9qXo/UE/yjub7VAkFhg+EI9sXXV0pi+TKWKrF0htpmjoHBzzRz4MdqhE3C6lj8aIrfmRg3lWxUpdYbTVVQvfp0PCWCnXq6y+02QU1RG/WgwHOohDVWr+y5BhzSMX+kP5LsuQENBGRG7LwBCADVsGLOw5YmYJXZQ8FWfwWmHJ6dalWsjI4S6ktBZ+u7gFXJwHbzYw3AYzTrWiBUU+ii0lUtVEQRfh4VeMrO/iufxGMwjquedZeZNzxU/nysEoh+D9cGwgPff RWhMBuktASgwULSyaR095YPslFfU0w/iZtoz3uM3YYedFGXyrydb2ZUv+i88LUKiY5qK+4HqaG6wsaS0Bx8vKymmVMSbZi/PWYHS5w+w5q71Z9fNRdF3MTMPIVvFH6mH1AULh6hRK/vH0UMEc2tN93szVupFvLBJVxf2doHjGNzvrytq0nTrRnl7jJspehC29cDKtJ6DtKmaw470bhClgAlE085UhuzABEBAAGJATYEGAEIACAWIQRZERbOg6XlNi+ijnEwmht7rUENtAUCZEbsvAIbDAAKCRAwmht7rUENtKM8B/9UyyyRA6/NQx2xzEibKxyYhHfP3OCPCbnFAyWT0TWF7OVSQg/Hc6PnrhDVUXLyrSxkXUaRtmxjxqhphhODH62jGrCn4nciczcrVwswFP53CMRQXdlpyW72LZ3wSo1XK1twWqFP48L+l00ZEbP3NXYk2rbuNKbyB6SBlmYZu+L6mEfZ+/eAoAgh9+ZCthNg+RsSwqfYwoO+bZXCjuWzLX2Tljg2yYhg+f9TotR6cW+sbcWi5cqjDmezsV0TIkE3FK9LN5Kzc8gUI/jSDSrW6rf72KTw7RgGdywW2VaA/XKz6GkaGReHeoZAetK9/2jxL6xQwDzr5gLUEuTBXG2lJ79O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 (by Flathub.org) MIME-Version: 1.0 Message-ID-Hash: MBT5WLW64YLOYRTOWD6LF2JEX7AEGKA2 X-Message-ID-Hash: MBT5WLW64YLOYRTOWD6LF2JEX7AEGKA2 X-MailFrom: luke@ljones.dev X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 2023-12-18 at 15:12 +0000, Stefan Binding wrote: > Add new model entries into configuration table. >=20 > Signed-off-by: Stefan Binding > --- > =C2=A0sound/pci/hda/cs35l41_hda_property.c | 36 > ++++++++++++++++++++++++++++ > =C2=A01 file changed, 36 insertions(+) >=20 > diff --git a/sound/pci/hda/cs35l41_hda_property.c > b/sound/pci/hda/cs35l41_hda_property.c > index f90423ded85d..a0d808ed640a 100644 > --- a/sound/pci/hda/cs35l41_hda_property.c > +++ b/sound/pci/hda/cs35l41_hda_property.c > @@ -42,6 +42,24 @@ static const struct cs35l41_config > cs35l41_config_table[] =3D { > =C2=A0 * in the ACPI. The Reset GPIO is also valid, so we can use the > Reset defined in _DSD. > =C2=A0 */ > =C2=A0 { "103C89C6", SPI, 2, INTERNAL, { CS35L41_RIGHT, > CS35L41_LEFT, 0, 0 }, -1, -1, -1, 1000, 4500, 24 }, > + { "10431433", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431463", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431473", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 }, > + { "10431483", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 }, > + { "10431493", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "104314D3", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "104314E3", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431503", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 }, > + { "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > + { "10431C9F", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431CAF", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431CCF", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431CDF", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431CEF", SPI, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, > + { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, > CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > =C2=A0 {} > =C2=A0}; > =C2=A0 Very good to see this work done. I have tested on 3 models and each one has very good sound now. Many thanks! > @@ -316,6 +334,24 @@ static const struct cs35l41_prop_model > cs35l41_prop_model_table[] =3D { > =C2=A0 { "CLSA0100", NULL, lenovo_legion_no_acpi }, > =C2=A0 { "CLSA0101", NULL, lenovo_legion_no_acpi }, > =C2=A0 { "CSC3551", "103C89C6", generic_dsd_config }, > + { "CSC3551", "10431433", generic_dsd_config }, > + { "CSC3551", "10431463", generic_dsd_config }, > + { "CSC3551", "10431473", generic_dsd_config }, > + { "CSC3551", "10431483", generic_dsd_config }, > + { "CSC3551", "10431493", generic_dsd_config }, > + { "CSC3551", "104314D3", generic_dsd_config }, > + { "CSC3551", "104314E3", generic_dsd_config }, > + { "CSC3551", "10431503", generic_dsd_config }, > + { "CSC3551", "10431533", generic_dsd_config }, > + { "CSC3551", "10431573", generic_dsd_config }, > + { "CSC3551", "10431663", generic_dsd_config }, > + { "CSC3551", "104317F3", generic_dsd_config }, > + { "CSC3551", "10431C9F", generic_dsd_config }, > + { "CSC3551", "10431CAF", generic_dsd_config }, > + { "CSC3551", "10431CCF", generic_dsd_config }, > + { "CSC3551", "10431CDF", generic_dsd_config }, > + { "CSC3551", "10431CEF", generic_dsd_config }, > + { "CSC3551", "10431D1F", generic_dsd_config }, > =C2=A0 {} > =C2=A0}; > =C2=A0