From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79847C388F7 for ; Tue, 10 Nov 2020 13:13:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14F8320674 for ; Tue, 10 Nov 2020 13:13:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="TWIJh1Ig"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XPuqv6Yp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14F8320674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 47709170E; Tue, 10 Nov 2020 14:12:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 47709170E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605014011; bh=w/cSws2QUy7hUE//cDz/Oq17kQNISQ8CBI4TwYili8s=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TWIJh1Igj0Hgsd+uE6iZmcBUwhysXkiAzBHpoFnpl71uKwGMl93tW4koTdpfV2bXp 93F4hkkN7T691vTL3ykjg5GJo8OqhmRm/RV6OxRFjvhAS9Ns2FyJ0tNed/n8cGDx4F 7UuPouwD6uJSm16xRK7B0CY5ia39nDlnStesLizk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CC329F80161; Tue, 10 Nov 2020 14:12:40 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A2228F800EB; Tue, 10 Nov 2020 14:12:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41EB3F800EB for ; Tue, 10 Nov 2020 14:12:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41EB3F800EB Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XPuqv6Yp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605013954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2V11rFQ3FKVTN+koXAVvig/bkOvKVZoOl9jWSSiZ8Ik=; b=XPuqv6Ypx/wUpiZ6DgU2js5eB0f6qaiR1GPjNU1LEMoa58Um4ODJBD6hBRZDQyXHJQsE4H 4DJtlAwMApiPW1/fBWenPFKRta/M714scmn0Yqi+DGPPzOgGkcrOesmg+IQpXgjmJov4Ie BOVxSQJ//VHyBIm8IKVvSHAWqEvjovw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-iQ_swDjrNvSFUT9T_TEokQ-1; Tue, 10 Nov 2020 08:12:31 -0500 X-MC-Unique: iQ_swDjrNvSFUT9T_TEokQ-1 Received: by mail-qk1-f197.google.com with SMTP id u16so8598432qkm.22 for ; Tue, 10 Nov 2020 05:12:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2V11rFQ3FKVTN+koXAVvig/bkOvKVZoOl9jWSSiZ8Ik=; b=VJE1B93+R9n8/vk9N1p3ipDjTHTAXsfhIiTMjiv991q86DENoYu8pbzTqWSG9wS4oy wVe7rkIGyx+Bs1jkjnklEnxTkj4tVk+U9B1WLml5ynoo8L+nfGyzw3pf7+dhdZDdB3wB WojqPt2HyH848D2OcPYdZWa64vk6HzN1ZUEOmTi2McFIPjdUAV8OqOisPMEtYDHAiY0S 9kErG9kMxWg9vfOJTLTxDBAVr+QRX8eMeq7UP75NWkPv/9HD7y/TgWSoYBCmeWLYFMft 6307ycgakhVn9efEIPJiy2zZYQqKG3sly5ePL9jHZq+qrvX30otE6uyl6mvwJ6/BNgEm BzCQ== X-Gm-Message-State: AOAM530/7glsYS7hhErWvLcqsu1T2CBmVY6SnHWjMk2bqmhUyqXrsyDA 4qaou/aYjo/S/rLBF9WUUsO7Q4y8rEKh4AA0n2YnWkHZimUS7sK1zcDg/MmnvLxYiucIjsZwm9d EboOaylaK7PdTYxkBQJZ+3fE= X-Received: by 2002:ac8:3621:: with SMTP id m30mr8787121qtb.168.1605013950656; Tue, 10 Nov 2020 05:12:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRnI1rUF5eW2rST1vImtIogpOlMRBum2fO0dVCe+zUlRqVIaRBqmVo31rjlhOk2kmW2Hr8dQ== X-Received: by 2002:ac8:3621:: with SMTP id m30mr8787064qtb.168.1605013950178; Tue, 10 Nov 2020 05:12:30 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id e8sm7658678qti.28.2020.11.10.05.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 05:12:29 -0800 (PST) Subject: Re: Subject: [RFC] clang tooling cleanups To: Joe Perches , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci References: <20201027164255.1573301-1-trix@redhat.com> <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> From: Tom Rix Message-ID: Date: Tue, 10 Nov 2020 05:12:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/9/20 6:52 PM, Joe Perches wrote: > On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: >> This rfc will describe >> An upcoming treewide cleanup. >> How clang tooling was used to programatically do the clean up. >> Solicit opinions on how to generally use clang tooling. >> >> The clang warning -Wextra-semi-stmt produces about 10k warnings. >> Reviewing these, a subset of semicolon after a switch looks safe to >> fix all the time. An example problem >> >> void foo(int a) { >>      switch(a) { >>       case 1: >> ... >>      }; <--- extra semicolon >> } >> >> Treewide, there are about 100 problems in 50 files for x86_64 allyesconfig. >> These fixes will be the upcoming cleanup. > coccinelle already does some of these. > > For instance: scripts/coccinelle/misc/semicolon.cocci > > Perhaps some tool coordination can be done here as > coccinelle/checkpatch/clang/Lindent call all be used > to do some facet or another of these cleanup issues. Thanks for pointing this out. I will take a look at it. Tom > >