From: Alexandrov Stanislav <neko@nya.ai>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Alsa Devel <alsa-devel@alsa-project.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.
Date: Fri, 06 Jan 2017 03:27:27 +0300 [thread overview]
Message-ID: <ced44ec93cd9ccd7c086d5f80b8972e5@nya.ai> (raw)
In-Reply-To: <20170105034948.GJ3573@localhost>
> Vinod Koul писал 2017-01-05 06:49:
>
> This looks okay, but title is same for both of the patches. It would be
> better to describe the change you are doing and not the outcome.
>
> so a better title could be:
>
> ASoC: rt5640: Add "10EC3276" ACPI ID
>
> and in log say:
>
> HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add
> that.
Thanks for comments. And i'm sorry for this inconvenience -_- I will
send new patchset with corrections.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-01-06 0:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 12:22 [PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Alexandrov Stansilav
2017-01-04 12:22 ` [PATCH v2 1/2] ASoC: rt5640: " Alexandrov Stansilav
2017-01-05 3:49 ` Vinod Koul
2017-01-06 0:27 ` Alexandrov Stanislav [this message]
2017-01-31 21:18 ` Applied "ASoC: rt5640: Add "10EC3276" ACPI ID" to the asoc tree Mark Brown
2017-01-04 12:22 ` [PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Alexandrov Stansilav
2017-01-05 3:52 ` Vinod Koul
2017-01-31 21:18 ` Applied "ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry" to the asoc tree Mark Brown
2017-01-04 16:41 ` [PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ced44ec93cd9ccd7c086d5f80b8972e5@nya.ai \
--to=neko@nya.ai \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).