From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 407ABC433EF for ; Tue, 12 Apr 2022 18:17:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 951F817F2; Tue, 12 Apr 2022 20:16:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 951F817F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649787421; bh=Z+vyaP6A2mSvC//XBPMaDHjI+2Rlpwre5h1sE96rL6w=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OCw/6oLGlq25pVE+5zgPnlxnAoxpP/Wb/j/eTl/FeDpdHjZauKMhXyrVEZDGyIxyu BJzLQ3VNRM0ckKpDtPU3KKQcMybbAJFPVvgU4sMDQ6LhStF3sm8PvutjRdA28C6vC6 2SFsZqRR6MFKUbfrgRh01xq9AI7zuXMmPdtlQ/HU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D125F80134; Tue, 12 Apr 2022 20:16:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E016F80154; Tue, 12 Apr 2022 20:16:09 +0200 (CEST) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 65D7FF8011C for ; Tue, 12 Apr 2022 20:15:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 65D7FF8011C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YV53AwGd" Received: by mail-lj1-x236.google.com with SMTP id o16so19235747ljp.3 for ; Tue, 12 Apr 2022 11:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bv3Ii30g4zGcWcAjSR2RS9vcLFQi9OzgY4tPm0Xq2DI=; b=YV53AwGdEEVgzCL5YdoQZETViwrr4M+mhHCyloRPNiBVNtmcBfdVBhj5spAJHCr839 kZtSOC9W7a/ByewNrfCcTZb7cPQIY4MJfbZqA5HJn3kBbDTTg/ZfPvxSEV5MRUpzWrWA y460MIcw0ZJMLrcZCMLG5DAnSXUEz/rE/CWFYntEAPmZv4pbd2mkdDNMAUEC7GZACJM7 8A+SE4CUvYdisEKXHNlUiH3gLBBuHLaDkca47ws/UwwDDwpAzluzQmqP90fO7oUmzewL KAF4erB55K5h/Xk2lqIpgdfvfrkrVcmyJPREZMksN5fmHJK8BqlxOU45xTyb/7IXdemY Lspg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bv3Ii30g4zGcWcAjSR2RS9vcLFQi9OzgY4tPm0Xq2DI=; b=Rp5qXiIzs9bucNZRtn4mjChsQwOx0+dDN7ENuEJz4qL3/srWxhzp36RnctX9ThRREi 0wIsGvAIdPC8CPczRSQDEwkdXr/X+4a5gTipeLBogeIi7wCevQYSLlRwg2vYsBw55BoH TkiwwKa1hzDtrk8YuWXJC8+7bnw28SS1BjIPbI3M6fBG/zvC4a1xumWr7YtidLY7668U tIdUC0t71EBpTvoXUImNIVlcXh/X3eGO20E09rTaanPex5FBEb75cIG0pLaBvYpstIkA frHCHVRytBOxHn6qpwYNycLhPtYHlx1Zud4zqVq0tLuoMSJPHu6dTR0jTEG9hGPoJKKN FHeg== X-Gm-Message-State: AOAM532PrJEursW1WlCY/v2jJqD43M41hW/hGgL2IKs0mswODoThTrtD GUfep7NXvVmrt1vrFpjwpmU= X-Google-Smtp-Source: ABdhPJyCwli3exPbuxaDOZra0Qqr/PAYhgR3s7Rs82OLpmiFF+a50aDqmTJPoBEdwbdy6CyNR84AvQ== X-Received: by 2002:a2e:a4c8:0:b0:249:7f70:50ad with SMTP id p8-20020a2ea4c8000000b002497f7050admr23420518ljm.171.1649787345883; Tue, 12 Apr 2022 11:15:45 -0700 (PDT) Received: from [10.0.0.127] (91-159-150-230.elisa-laajakaista.fi. [91.159.150.230]) by smtp.gmail.com with ESMTPSA id f17-20020a2e1f11000000b00247f8eb86a7sm3358565ljf.108.2022.04.12.11.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 11:15:45 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 21:16:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] ASoC: ti: osk5912: Make it CCF clk API compatible Content-Language: en-US To: Janusz Krzysztofik , Mark Brown References: <20220402120106.131118-1-jmkrzyszt@gmail.com> <20220407191202.46206-1-jmkrzyszt@gmail.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= In-Reply-To: <20220407191202.46206-1-jmkrzyszt@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Liam Girdwood X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 07/04/2022 22:12, Janusz Krzysztofik wrote: > The driver, OMAP1 specific, now omits clk_prepare/unprepare() steps, not > supported by OMAP1 custom implementation of clock API. However, non-CCF > stubs of those functions exist for use on such platforms until converted > to CCF. > > Update the driver to be compatible with CCF implementation of clock API. > > v2: use clk_prepare_enable/clk_disable_unprepare() (Peter) Does the changelogn needs to be in the commit message? I almost missed the V2 as it came as a reply to a thread ;) Other than the nitpick with the changlog placement: Looks good but I can not test it, Acked-by: Peter Ujfalusi > > Signed-off-by: Janusz Krzysztofik > --- > sound/soc/ti/osk5912.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/ti/osk5912.c b/sound/soc/ti/osk5912.c > index 40e29dda7e7a..2790c8915f55 100644 > --- a/sound/soc/ti/osk5912.c > +++ b/sound/soc/ti/osk5912.c > @@ -27,12 +27,12 @@ static struct clk *tlv320aic23_mclk; > > static int osk_startup(struct snd_pcm_substream *substream) > { > - return clk_enable(tlv320aic23_mclk); > + return clk_prepare_enable(tlv320aic23_mclk); > } > > static void osk_shutdown(struct snd_pcm_substream *substream) > { > - clk_disable(tlv320aic23_mclk); > + clk_disable_unprepare(tlv320aic23_mclk); > } > > static int osk_hw_params(struct snd_pcm_substream *substream, -- Péter