* [PATCH 00/49] Use vzalloc not vmalloc/kmemset [not found] <alpine.DEB.2.00.1011031108260.11625@router.home> @ 2010-11-05 3:07 ` Joe Perches 2010-11-05 3:08 ` [PATCH 48/49] sound/oss/dev_table.c: Use vzalloc Joe Perches 0 siblings, 1 reply; 3+ messages in thread From: Joe Perches @ 2010-11-05 3:07 UTC (permalink / raw) To: Jiri Kosina Cc: linux-ia64, linux-kernel, linux-mips, kvm, kvm-ppc, linuxppc-dev, cbe-oss-dev, linux-s390, amd64-microcode, linux-crypto, linux-atm-general, netdev, drbd-user, dri-devel, linux-input, linux-rdma, dm-devel, linux-raid, linux-media, linux-mtd, e1000-devel, linux-scsi, osst-users, devel, xen-devel, virtualization, linux-ext4, reiserfs-devel, xfs, codalist, linux-mm Converted vmalloc/memset and vmalloc_node/memset to vzalloc or vzalloc_node using a cocci script and some editing Reduces text a little bit. Compiled x86 only. There are still vmalloc_32 with memset calls still around. Broken out to multiple patches to cc appropriate maintainers. Joe Perches (49): arch/ia64: Use vzalloc arch/mips: Use vzalloc arch/powerpc: Use vzalloc arch/s390: Use vzalloc arch/x86: Use vzalloc crypto: Use vzalloc drivers/atm: Use vzalloc drivers/block: Use vzalloc drivers/char: Use vzalloc drivers/gpu: Use vzalloc drivers/hid: Use vzalloc drivers/infiniband: Use vzalloc drivers/isdn: Use vzalloc drivers/md: Use vzalloc drivers/media: Use vzalloc drivers/mtd: Use vzalloc drivers/net/cxgb3: Use vzalloc drivers/net/cxgb4: Use vzalloc drivers/net/e1000: Use vzalloc drivers/net/e1000e: Use vzalloc drivers/net/ehea: Use vzalloc drivers/net/igb: Use vzalloc drivers/net/igbvf: Use vzalloc drivers/net/ixgb: Use vzalloc drivers/net/ixgbe: Use vzalloc drivers/net/ixgbevf: Use vzalloc drivers/net/netxen: Use vzalloc drivers/net/pch_gbe: Use vzalloc drivers/net/qlcnic: Use vzalloc drivers/net/sfc: Use vzalloc drivers/net/vxge: Use vzalloc drivers/net/bnx2.c: Use vzalloc drivers/s390: Use vzalloc drivers/scsi: Use vzalloc drivers/staging: Use vzalloc drivers/video: Use vzalloc fs/ext4: Use vzalloc fs/jffs2: Use vzalloc fs/reiserfs: Use vzalloc fs/udf: Use vzalloc fs/xfs: Use vzalloc include/linux/coda_linux.h: Use vzalloc kernel: Use vzalloc mm: Use vzalloc net/core/pktgen.c: Use vzalloc net/netfilter: Use vzalloc net/rds: Use vzalloc sound/oss/dev_table.c: Use vzalloc virt/kvm/kvm_main.c: Use vzalloc arch/ia64/kernel/perfmon.c | 3 +- arch/mips/sibyte/common/sb_tbprof.c | 3 +- arch/powerpc/kvm/book3s.c | 6 +-- arch/powerpc/platforms/cell/spufs/lscsa_alloc.c | 3 +- arch/s390/hypfs/hypfs_diag.c | 3 +- arch/x86/kernel/microcode_amd.c | 3 +- arch/x86/kvm/x86.c | 3 +- arch/x86/mm/pageattr-test.c | 3 +- crypto/deflate.c | 3 +- crypto/zlib.c | 3 +- drivers/atm/idt77252.c | 11 ++++--- drivers/atm/lanai.c | 3 +- drivers/block/drbd/drbd_bitmap.c | 5 +-- drivers/char/agp/backend.c | 3 +- drivers/char/mspec.c | 5 +-- drivers/gpu/drm/via/via_dmablit.c | 4 +- drivers/hid/hid-core.c | 3 +- drivers/infiniband/hw/amso1100/c2_rnic.c | 5 +-- drivers/infiniband/hw/ehca/ipz_pt_fn.c | 5 +-- drivers/infiniband/hw/ipath/ipath_driver.c | 3 +- drivers/infiniband/hw/ipath/ipath_file_ops.c | 11 ++----- drivers/infiniband/hw/ipath/ipath_init_chip.c | 5 +-- drivers/infiniband/hw/qib/qib_init.c | 7 +--- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 10 ++---- drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +- drivers/isdn/i4l/isdn_common.c | 4 +- drivers/isdn/mISDN/dsp_core.c | 3 +- drivers/isdn/mISDN/l1oip_codec.c | 6 +-- drivers/md/dm-log.c | 3 +- drivers/md/dm-snap-persistent.c | 3 +- drivers/md/dm-table.c | 4 +-- drivers/media/dvb/ngene/ngene-core.c | 3 +- drivers/media/video/mx3_camera.c | 3 +- drivers/media/video/pwc/pwc-if.c | 3 +- drivers/media/video/videobuf-dma-sg.c | 3 +- drivers/mtd/nand/nandsim.c | 3 +- drivers/mtd/ubi/vtbl.c | 6 +-- drivers/net/bnx2.c | 10 +----- drivers/net/cxgb3/cxgb3_offload.c | 7 ++-- drivers/net/cxgb4/cxgb4_main.c | 7 ++-- drivers/net/e1000/e1000_main.c | 6 +-- drivers/net/e1000e/netdev.c | 6 +-- drivers/net/ehea/ehea_main.c | 4 +-- drivers/net/igb/igb_main.c | 6 +-- drivers/net/igbvf/netdev.c | 6 +-- drivers/net/ixgb/ixgb_main.c | 6 +-- drivers/net/ixgbe/ixgbe_main.c | 10 ++---- drivers/net/ixgbevf/ixgbevf_main.c | 6 +-- drivers/net/netxen/netxen_nic_init.c | 7 +--- drivers/net/pch_gbe/pch_gbe_main.c | 6 +-- drivers/net/qlcnic/qlcnic_init.c | 7 +--- drivers/net/sfc/filter.c | 3 +- drivers/net/vxge/vxge-config.c | 37 +++++----------------- drivers/s390/cio/blacklist.c | 3 +- drivers/scsi/bfa/bfad.c | 3 +- drivers/scsi/bfa/bfad_debugfs.c | 8 +---- drivers/scsi/cxgbi/libcxgbi.h | 9 ++---- drivers/scsi/osst.c | 3 +- drivers/scsi/qla2xxx/qla_attr.c | 3 +- drivers/scsi/qla2xxx/qla_bsg.c | 3 +- drivers/scsi/scsi_debug.c | 7 +--- drivers/staging/comedi/drivers.c | 4 +-- drivers/staging/rtl8192e/r8192E_core.c | 4 +-- drivers/staging/udlfb/udlfb.c | 5 +-- drivers/staging/xgifb/XGI_main_26.c | 3 +- drivers/staging/zram/zram_drv.c | 3 +- drivers/video/arcfb.c | 5 +-- drivers/video/broadsheetfb.c | 4 +-- drivers/video/hecubafb.c | 5 +-- drivers/video/metronomefb.c | 4 +-- drivers/video/xen-fbfront.c | 3 +- fs/ext4/super.c | 4 +-- fs/jffs2/build.c | 5 +-- fs/reiserfs/journal.c | 9 ++---- fs/reiserfs/resize.c | 4 +-- fs/udf/super.c | 5 +-- fs/xfs/linux-2.6/kmem.h | 7 +---- include/linux/coda_linux.h | 26 ++++++++++------ kernel/profile.c | 6 +-- kernel/relay.c | 4 +-- mm/memcontrol.c | 5 +-- mm/page_cgroup.c | 3 +- mm/percpu.c | 8 +---- mm/swapfile.c | 3 +- net/core/pktgen.c | 3 +- net/netfilter/x_tables.c | 5 +-- net/rds/ib_cm.c | 6 +-- sound/oss/dev_table.c | 6 +-- virt/kvm/kvm_main.c | 13 ++------ 89 files changed, 167 insertions(+), 328 deletions(-) -- 1.7.3.1.g432b3.dirty -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 48/49] sound/oss/dev_table.c: Use vzalloc 2010-11-05 3:07 ` [PATCH 00/49] Use vzalloc not vmalloc/kmemset Joe Perches @ 2010-11-05 3:08 ` Joe Perches 2010-11-22 6:59 ` Takashi Iwai 0 siblings, 1 reply; 3+ messages in thread From: Joe Perches @ 2010-11-05 3:08 UTC (permalink / raw) To: Jiri Kosina; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- sound/oss/dev_table.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/oss/dev_table.c b/sound/oss/dev_table.c index 727bdb9..d8cf3e5 100644 --- a/sound/oss/dev_table.c +++ b/sound/oss/dev_table.c @@ -71,7 +71,7 @@ int sound_install_audiodrv(int vers, char *name, struct audio_driver *driver, if (sound_nblocks >= MAX_MEM_BLOCKS) sound_nblocks = MAX_MEM_BLOCKS - 1; - op = (struct audio_operations *) (sound_mem_blocks[sound_nblocks] = vmalloc(sizeof(struct audio_operations))); + op = (struct audio_operations *) (sound_mem_blocks[sound_nblocks] = vzalloc(sizeof(struct audio_operations))); sound_nblocks++; if (sound_nblocks >= MAX_MEM_BLOCKS) sound_nblocks = MAX_MEM_BLOCKS - 1; @@ -81,7 +81,6 @@ int sound_install_audiodrv(int vers, char *name, struct audio_driver *driver, sound_unload_audiodev(num); return -(ENOMEM); } - memset((char *) op, 0, sizeof(struct audio_operations)); init_waitqueue_head(&op->in_sleeper); init_waitqueue_head(&op->out_sleeper); init_waitqueue_head(&op->poll_sleeper); @@ -128,7 +127,7 @@ int sound_install_mixer(int vers, char *name, struct mixer_operations *driver, /* FIXME: This leaks a mixer_operations struct every time its called until you unload sound! */ - op = (struct mixer_operations *) (sound_mem_blocks[sound_nblocks] = vmalloc(sizeof(struct mixer_operations))); + op = (struct mixer_operations *) (sound_mem_blocks[sound_nblocks] = vzalloc(sizeof(struct mixer_operations))); sound_nblocks++; if (sound_nblocks >= MAX_MEM_BLOCKS) sound_nblocks = MAX_MEM_BLOCKS - 1; @@ -137,7 +136,6 @@ int sound_install_mixer(int vers, char *name, struct mixer_operations *driver, printk(KERN_ERR "Sound: Can't allocate mixer driver for (%s)\n", name); return -ENOMEM; } - memset((char *) op, 0, sizeof(struct mixer_operations)); memcpy((char *) op, (char *) driver, driver_size); strlcpy(op->name, name, sizeof(op->name)); -- 1.7.3.1.g432b3.dirty ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 48/49] sound/oss/dev_table.c: Use vzalloc 2010-11-05 3:08 ` [PATCH 48/49] sound/oss/dev_table.c: Use vzalloc Joe Perches @ 2010-11-22 6:59 ` Takashi Iwai 0 siblings, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2010-11-22 6:59 UTC (permalink / raw) To: Joe Perches; +Cc: alsa-devel, Jiri Kosina, linux-kernel At Thu, 4 Nov 2010 20:08:12 -0700, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> Thanks, applied. [Sorry to be late, this has been already applied in my tree but this reply mail wasn't triggered to be sent out until now...] Takashi > --- > sound/oss/dev_table.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/oss/dev_table.c b/sound/oss/dev_table.c > index 727bdb9..d8cf3e5 100644 > --- a/sound/oss/dev_table.c > +++ b/sound/oss/dev_table.c > @@ -71,7 +71,7 @@ int sound_install_audiodrv(int vers, char *name, struct audio_driver *driver, > if (sound_nblocks >= MAX_MEM_BLOCKS) > sound_nblocks = MAX_MEM_BLOCKS - 1; > > - op = (struct audio_operations *) (sound_mem_blocks[sound_nblocks] = vmalloc(sizeof(struct audio_operations))); > + op = (struct audio_operations *) (sound_mem_blocks[sound_nblocks] = vzalloc(sizeof(struct audio_operations))); > sound_nblocks++; > if (sound_nblocks >= MAX_MEM_BLOCKS) > sound_nblocks = MAX_MEM_BLOCKS - 1; > @@ -81,7 +81,6 @@ int sound_install_audiodrv(int vers, char *name, struct audio_driver *driver, > sound_unload_audiodev(num); > return -(ENOMEM); > } > - memset((char *) op, 0, sizeof(struct audio_operations)); > init_waitqueue_head(&op->in_sleeper); > init_waitqueue_head(&op->out_sleeper); > init_waitqueue_head(&op->poll_sleeper); > @@ -128,7 +127,7 @@ int sound_install_mixer(int vers, char *name, struct mixer_operations *driver, > /* FIXME: This leaks a mixer_operations struct every time its called > until you unload sound! */ > > - op = (struct mixer_operations *) (sound_mem_blocks[sound_nblocks] = vmalloc(sizeof(struct mixer_operations))); > + op = (struct mixer_operations *) (sound_mem_blocks[sound_nblocks] = vzalloc(sizeof(struct mixer_operations))); > sound_nblocks++; > if (sound_nblocks >= MAX_MEM_BLOCKS) > sound_nblocks = MAX_MEM_BLOCKS - 1; > @@ -137,7 +136,6 @@ int sound_install_mixer(int vers, char *name, struct mixer_operations *driver, > printk(KERN_ERR "Sound: Can't allocate mixer driver for (%s)\n", name); > return -ENOMEM; > } > - memset((char *) op, 0, sizeof(struct mixer_operations)); > memcpy((char *) op, (char *) driver, driver_size); > > strlcpy(op->name, name, sizeof(op->name)); > -- > 1.7.3.1.g432b3.dirty > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-22 6:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.DEB.2.00.1011031108260.11625@router.home>
2010-11-05 3:07 ` [PATCH 00/49] Use vzalloc not vmalloc/kmemset Joe Perches
2010-11-05 3:08 ` [PATCH 48/49] sound/oss/dev_table.c: Use vzalloc Joe Perches
2010-11-22 6:59 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).