[parent not found: <cover.1384352281.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* [PATCH v7 1/4] dma: imx-sdma: Add sdma firmware version 2 support
[not found] ` <cover.1384352281.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
@ 2013-11-13 14:55 ` Nicolin Chen
0 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2013-11-13 14:55 UTC (permalink / raw)
To: vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w,
s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ, timur-N01EOCouUvQ,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A, broonie-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-doc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dmaengine-u79uwXL29TY76Z2rM5mHXA,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, mark.rutland-5wv7dgnIgG8,
swarren-3lzwWm7+Weoh9ZMKESR00Q, pawel.moll-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg
On i.MX5/6 series, SDMA is using new version firmware to support SSI
dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it.
Signed-off-by: Nicolin Chen <b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Acked-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/dma/imx-sdma.c | 15 ++++++++++++++-
include/linux/platform_data/dma-imx-sdma.h | 5 +++++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index fc43603..43a8441 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -323,6 +323,7 @@ struct sdma_engine {
struct clk *clk_ipg;
struct clk *clk_ahb;
spinlock_t channel_0_lock;
+ u32 script_number;
struct sdma_script_start_addrs *script_addrs;
const struct sdma_driver_data *drvdata;
};
@@ -1238,6 +1239,7 @@ static void sdma_issue_pending(struct dma_chan *chan)
}
#define SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1 34
+#define SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2 38
static void sdma_add_scripts(struct sdma_engine *sdma,
const struct sdma_script_start_addrs *addr)
@@ -1246,7 +1248,7 @@ static void sdma_add_scripts(struct sdma_engine *sdma,
s32 *saddr_arr = (u32 *)sdma->script_addrs;
int i;
- for (i = 0; i < SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1; i++)
+ for (i = 0; i < sdma->script_number; i++)
if (addr_arr[i] > 0)
saddr_arr[i] = addr_arr[i];
}
@@ -1272,6 +1274,17 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
goto err_firmware;
if (header->ram_code_start + header->ram_code_size > fw->size)
goto err_firmware;
+ switch (header->version_major) {
+ case 1:
+ sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;
+ break;
+ case 2:
+ sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2;
+ break;
+ default:
+ dev_err(sdma->dev, "unknown firmware version\n");
+ goto err_firmware;
+ }
addr = (void *)header + header->script_addrs_start;
ram_code = (void *)header + header->ram_code_start;
diff --git a/include/linux/platform_data/dma-imx-sdma.h b/include/linux/platform_data/dma-imx-sdma.h
index 3a39428..eabac4e 100644
--- a/include/linux/platform_data/dma-imx-sdma.h
+++ b/include/linux/platform_data/dma-imx-sdma.h
@@ -43,6 +43,11 @@ struct sdma_script_start_addrs {
s32 dptc_dvfs_addr;
s32 utra_addr;
s32 ram_code_start_addr;
+ /* End of v1 array */
+ s32 mcu_2_ssish_addr;
+ s32 ssish_2_mcu_addr;
+ s32 hdmi_dma_addr;
+ /* End of v2 array */
};
/**
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script
2013-11-13 14:55 [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
[not found] ` <cover.1384352281.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
@ 2013-11-13 14:55 ` Nicolin Chen
2013-11-13 14:55 ` [PATCH v7 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2013-11-13 14:55 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, s.hauer, timur, shawn.guo, broonie
Cc: linux-arm-kernel, devicetree, linux-doc, linux-kernel, dmaengine,
linuxppc-dev, alsa-devel, rob.herring, mark.rutland, swarren,
pawel.moll, ijc+devicetree
This patch adds a new DMA_TYPE for SSI dual FIFO script, included
in SDMA firmware version 2. This script would allow SSI use dual
fifo mode to transimit/receive data without occasional hardware
underrun/overrun.
Signed-off-by: Nicolin Chen <b42378@freescale.com>
Acked-by: Kumar Gala <galak@codeaurora.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 +
drivers/dma/imx-sdma.c | 4 ++++
include/linux/platform_data/dma-imx.h | 1 +
3 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt
index 4fa814d..68b83ec 100644
--- a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt
+++ b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt
@@ -42,6 +42,7 @@ The full ID of peripheral types can be found below.
19 IPU Memory
20 ASRC
21 ESAI
+ 22 SSI Dual FIFO (needs firmware ver >= 2)
The third cell specifies the transfer priority as below.
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 43a8441..efe9d6a 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -725,6 +725,10 @@ static void sdma_get_pc(struct sdma_channel *sdmac,
per_2_emi = sdma->script_addrs->app_2_mcu_addr;
emi_2_per = sdma->script_addrs->mcu_2_app_addr;
break;
+ case IMX_DMATYPE_SSI_DUAL:
+ per_2_emi = sdma->script_addrs->ssish_2_mcu_addr;
+ emi_2_per = sdma->script_addrs->mcu_2_ssish_addr;
+ break;
case IMX_DMATYPE_SSI_SP:
case IMX_DMATYPE_MMC:
case IMX_DMATYPE_SDHC:
diff --git a/include/linux/platform_data/dma-imx.h b/include/linux/platform_data/dma-imx.h
index beac6b8..bcbc6c3 100644
--- a/include/linux/platform_data/dma-imx.h
+++ b/include/linux/platform_data/dma-imx.h
@@ -39,6 +39,7 @@ enum sdma_peripheral_type {
IMX_DMATYPE_IPU_MEMORY, /* IPU Memory */
IMX_DMATYPE_ASRC, /* ASRC */
IMX_DMATYPE_ESAI, /* ESAI */
+ IMX_DMATYPE_SSI_DUAL, /* SSI Dual FIFO */
};
enum imx_dma_prio {
--
1.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v7 3/4] ASoC: fsl_ssi: Add dual fifo mode support
2013-11-13 14:55 [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
[not found] ` <cover.1384352281.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-11-13 14:55 ` [PATCH v7 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script Nicolin Chen
@ 2013-11-13 14:55 ` Nicolin Chen
2013-11-13 14:55 ` [PATCH v7 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2013-11-13 14:55 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, s.hauer, timur, shawn.guo, broonie
Cc: linux-arm-kernel, devicetree, linux-doc, linux-kernel, dmaengine,
linuxppc-dev, alsa-devel, rob.herring, mark.rutland, swarren,
pawel.moll, ijc+devicetree
By enabling dual fifo mode, it would allow SSI enter a better performance
to transimit/receive data without occasional hardware underrun/overrun.
Signed-off-by: Nicolin Chen <b42378@freescale.com>
Acked-by: Timur Tabi <timur@tabi.org>
Acked-by: Mark Brown <broonie@linaro.org>
---
sound/soc/fsl/fsl_ssi.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 35e2773..f43be6d 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -143,6 +143,7 @@ struct fsl_ssi_private {
bool ssi_on_imx;
bool imx_ac97;
bool use_dma;
+ bool use_dual_fifo;
struct clk *clk;
struct snd_dmaengine_dai_dma_data dma_params_tx;
struct snd_dmaengine_dai_dma_data dma_params_rx;
@@ -413,6 +414,12 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
write_ssi(CCSR_SSI_SOR_WAIT(3), &ssi->sor);
}
+ if (ssi_private->use_dual_fifo) {
+ write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
+ write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
+ write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN);
+ }
+
return 0;
}
@@ -480,6 +487,15 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
ssi_private->second_stream = substream;
}
+ /* When using dual fifo mode, it is safer to ensure an even period
+ * size. If appearing to an odd number while DMA always starts its
+ * task from fifo0, fifo1 would be neglected at the end of each
+ * period. But SSI would still access fifo1 with an invalid data.
+ */
+ if (ssi_private->use_dual_fifo)
+ snd_pcm_hw_constraint_step(substream->runtime, 0,
+ SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 2);
+
return 0;
}
@@ -947,7 +963,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
ssi_private->fifo_depth = 8;
if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx21-ssi")) {
- u32 dma_events[2];
+ u32 dma_events[2], dmas[4];
ssi_private->ssi_on_imx = true;
ssi_private->clk = devm_clk_get(&pdev->dev, NULL);
@@ -1001,6 +1017,15 @@ static int fsl_ssi_probe(struct platform_device *pdev)
dma_events[0], shared ? IMX_DMATYPE_SSI_SP : IMX_DMATYPE_SSI);
imx_pcm_dma_params_init_data(&ssi_private->filter_data_rx,
dma_events[1], shared ? IMX_DMATYPE_SSI_SP : IMX_DMATYPE_SSI);
+ if (!of_property_read_u32_array(pdev->dev.of_node, "dmas", dmas, 4)
+ && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
+ ssi_private->use_dual_fifo = true;
+ /* When using dual fifo mode, we need to keep watermark
+ * as even numbers due to dma script limitation.
+ */
+ ssi_private->dma_params_tx.maxburst &= ~0x1;
+ ssi_private->dma_params_rx.maxburst &= ~0x1;
+ }
} else if (ssi_private->use_dma) {
/* The 'name' should not have any slashes in it. */
ret = devm_request_irq(&pdev->dev, ssi_private->irq,
--
1.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v7 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi
2013-11-13 14:55 [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
` (2 preceding siblings ...)
2013-11-13 14:55 ` [PATCH v7 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
@ 2013-11-13 14:55 ` Nicolin Chen
2013-11-22 16:31 ` [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-11-28 8:41 ` Vinod Koul
5 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2013-11-13 14:55 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, s.hauer, timur, shawn.guo, broonie
Cc: linux-arm-kernel, devicetree, linux-doc, linux-kernel, dmaengine,
linuxppc-dev, alsa-devel, rob.herring, mark.rutland, swarren,
pawel.moll, ijc+devicetree
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series.
Signed-off-by: Nicolin Chen <b42378@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/boot/dts/imx51.dtsi | 4 ++--
arch/arm/boot/dts/imx53.dtsi | 4 ++--
arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------
arch/arm/boot/dts/imx6sl.dtsi | 12 ++++++------
4 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 54cee65..1a71eac 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -154,8 +154,8 @@
reg = <0x70014000 0x4000>;
interrupts = <30>;
clocks = <&clks 49>;
- dmas = <&sdma 24 1 0>,
- <&sdma 25 1 0>;
+ dmas = <&sdma 24 22 0>,
+ <&sdma 25 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
fsl,ssi-dma-events = <25 24 23 22>; /* TX0 RX0 TX1 RX1 */
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 4307e80..7208fde 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -153,8 +153,8 @@
reg = <0x50014000 0x4000>;
interrupts = <30>;
clocks = <&clks 49>;
- dmas = <&sdma 24 1 0>,
- <&sdma 25 1 0>;
+ dmas = <&sdma 24 22 0>,
+ <&sdma 25 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
fsl,ssi-dma-events = <25 24 23 22>; /* TX0 RX0 TX1 RX1 */
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 57e9c38..6e096ca 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -223,8 +223,8 @@
reg = <0x02028000 0x4000>;
interrupts = <0 46 0x04>;
clocks = <&clks 178>;
- dmas = <&sdma 37 1 0>,
- <&sdma 38 1 0>;
+ dmas = <&sdma 37 22 0>,
+ <&sdma 38 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
fsl,ssi-dma-events = <38 37>;
@@ -236,8 +236,8 @@
reg = <0x0202c000 0x4000>;
interrupts = <0 47 0x04>;
clocks = <&clks 179>;
- dmas = <&sdma 41 1 0>,
- <&sdma 42 1 0>;
+ dmas = <&sdma 41 22 0>,
+ <&sdma 42 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
fsl,ssi-dma-events = <42 41>;
@@ -249,8 +249,8 @@
reg = <0x02030000 0x4000>;
interrupts = <0 48 0x04>;
clocks = <&clks 180>;
- dmas = <&sdma 45 1 0>,
- <&sdma 46 1 0>;
+ dmas = <&sdma 45 22 0>,
+ <&sdma 46 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
fsl,ssi-dma-events = <46 45>;
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index c46651e..b32ba99 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -195,8 +195,8 @@
reg = <0x02028000 0x4000>;
interrupts = <0 46 0x04>;
clocks = <&clks IMX6SL_CLK_SSI1>;
- dmas = <&sdma 37 1 0>,
- <&sdma 38 1 0>;
+ dmas = <&sdma 37 22 0>,
+ <&sdma 38 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
status = "disabled";
@@ -207,8 +207,8 @@
reg = <0x0202c000 0x4000>;
interrupts = <0 47 0x04>;
clocks = <&clks IMX6SL_CLK_SSI2>;
- dmas = <&sdma 41 1 0>,
- <&sdma 42 1 0>;
+ dmas = <&sdma 41 22 0>,
+ <&sdma 42 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
status = "disabled";
@@ -219,8 +219,8 @@
reg = <0x02030000 0x4000>;
interrupts = <0 48 0x04>;
clocks = <&clks IMX6SL_CLK_SSI3>;
- dmas = <&sdma 45 1 0>,
- <&sdma 46 1 0>;
+ dmas = <&sdma 45 22 0>,
+ <&sdma 46 22 0>;
dma-names = "rx", "tx";
fsl,fifo-depth = <15>;
status = "disabled";
--
1.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi
2013-11-13 14:55 [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
` (3 preceding siblings ...)
2013-11-13 14:55 ` [PATCH v7 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
@ 2013-11-22 16:31 ` Nicolin Chen
2013-11-25 2:11 ` Shawn Guo
2013-11-28 8:41 ` Vinod Koul
5 siblings, 1 reply; 8+ messages in thread
From: Nicolin Chen @ 2013-11-22 16:31 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, s.hauer, timur, shawn.guo, broonie
Cc: mark.rutland, devicetree, alsa-devel, pawel.moll, swarren,
linux-doc, linux-kernel, rob.herring, dmaengine, ijc+devicetree,
linuxppc-dev, linux-arm-kernel
Hi all,
I'm sorry to push this. But this series has been an orphan for a while.
Could any one please receive and foster it?
Thank you.
Nicolin Chen
On Wed, Nov 13, 2013 at 10:55:23PM +0800, Nicolin Chen wrote:
> * ! This series of patches has a direct dependency between them. When
> * ! applying them, we need to apply to one single branch. Otherwise,
> * ! it would break currect branches.
>
> Changelog
> v7:
> * Appended missing Acked-by to all four patches.
> * Sorry that I didn't add them at the first place.
> v6:
> * PATCH-1: Use goto err_firmware instead of return directly.
> *
> * Nothing changes for the other three ack-ed patches
> v5:
> * PATCH-3: Add period size constraint when using dual fifo mode
> *
> * Nothing changes for the other three patches
> v4:
> * PATCH-3: Drop useless register configuration.
> *
> * Nothing changes for the other three patches
> v3:
> * PATCH-1: Add comments to indicate the end of v1 and v2 array.
> * PATCH-3: Use better way to keep watermark as even number.
> *
> * Nothing changes for PATCH-2 and PATCH-4
> v2:
> * Instead of adding rogue scripts to current SDMA driver based on firmware
> * V1, we define the new SDMA firmware as version 2 and bisect the PATCH-1
> * to two patches: The first is to add version check code to the SDMA driver;
> * And the second is to add SSI dual FIFO DMATYPE.
> *
> * Nothing changes for the last two patches.
> v1:
> * SSI can reduce hardware overrun/underrun possibility when using dual
> * fifo mode. To support this mode, we need to first update sdma sciprt
> * list, and then enable dual fifo BIT in SSI driver, and last update DT
> * bindings of i.MX series.
>
> Nicolin Chen (4):
> dma: imx-sdma: Add sdma firmware version 2 support
> dma: imx-sdma: Add new dma type for ssi dual fifo script
> ASoC: fsl_ssi: Add dual fifo mode support
> ARM: dts: imx: use dual-fifo sdma script for ssi
>
> .../devicetree/bindings/dma/fsl-imx-sdma.txt | 1 +
> arch/arm/boot/dts/imx51.dtsi | 4 ++--
> arch/arm/boot/dts/imx53.dtsi | 4 ++--
> arch/arm/boot/dts/imx6qdl.dtsi | 12 +++++-----
> arch/arm/boot/dts/imx6sl.dtsi | 12 +++++-----
> drivers/dma/imx-sdma.c | 19 ++++++++++++++-
> include/linux/platform_data/dma-imx-sdma.h | 5 ++++
> include/linux/platform_data/dma-imx.h | 1 +
> sound/soc/fsl/fsl_ssi.c | 27 +++++++++++++++++++++-
> 9 files changed, 67 insertions(+), 18 deletions(-)
>
> --
> 1.8.4
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi
2013-11-22 16:31 ` [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
@ 2013-11-25 2:11 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2013-11-25 2:11 UTC (permalink / raw)
To: Nicolin Chen
Cc: vinod.koul, dan.j.williams, s.hauer, timur, broonie, mark.rutland,
devicetree, alsa-devel, pawel.moll, linux-doc, swarren,
linux-kernel, rob.herring, dmaengine, ijc+devicetree,
linuxppc-dev, linux-arm-kernel
On Sat, Nov 23, 2013 at 12:31:32AM +0800, Nicolin Chen wrote:
> Hi all,
>
> I'm sorry to push this. But this series has been an orphan for a while.
> Could any one please receive and foster it?
Vinod,
I expect you will pick up the series. But otherwise, I can apply it via
IMX tree with your ACKs on the first two patches.
Shawn
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi
2013-11-13 14:55 [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
` (4 preceding siblings ...)
2013-11-22 16:31 ` [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
@ 2013-11-28 8:41 ` Vinod Koul
5 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2013-11-28 8:41 UTC (permalink / raw)
To: Nicolin Chen
Cc: dan.j.williams, s.hauer, timur, shawn.guo, broonie,
linux-arm-kernel, devicetree, linux-doc, linux-kernel, dmaengine,
linuxppc-dev, alsa-devel, rob.herring, mark.rutland, swarren,
pawel.moll, ijc+devicetree
On Wed, Nov 13, 2013 at 10:55:23PM +0800, Nicolin Chen wrote:
> * ! This series of patches has a direct dependency between them. When
> * ! applying them, we need to apply to one single branch. Otherwise,
> * ! it would break currect branches.
Applied, thanks
--
~Vinod
>
> Changelog
> v7:
> * Appended missing Acked-by to all four patches.
> * Sorry that I didn't add them at the first place.
> v6:
> * PATCH-1: Use goto err_firmware instead of return directly.
> *
> * Nothing changes for the other three ack-ed patches
> v5:
> * PATCH-3: Add period size constraint when using dual fifo mode
> *
> * Nothing changes for the other three patches
> v4:
> * PATCH-3: Drop useless register configuration.
> *
> * Nothing changes for the other three patches
> v3:
> * PATCH-1: Add comments to indicate the end of v1 and v2 array.
> * PATCH-3: Use better way to keep watermark as even number.
> *
> * Nothing changes for PATCH-2 and PATCH-4
> v2:
> * Instead of adding rogue scripts to current SDMA driver based on firmware
> * V1, we define the new SDMA firmware as version 2 and bisect the PATCH-1
> * to two patches: The first is to add version check code to the SDMA driver;
> * And the second is to add SSI dual FIFO DMATYPE.
> *
> * Nothing changes for the last two patches.
> v1:
> * SSI can reduce hardware overrun/underrun possibility when using dual
> * fifo mode. To support this mode, we need to first update sdma sciprt
> * list, and then enable dual fifo BIT in SSI driver, and last update DT
> * bindings of i.MX series.
>
> Nicolin Chen (4):
> dma: imx-sdma: Add sdma firmware version 2 support
> dma: imx-sdma: Add new dma type for ssi dual fifo script
> ASoC: fsl_ssi: Add dual fifo mode support
> ARM: dts: imx: use dual-fifo sdma script for ssi
>
> .../devicetree/bindings/dma/fsl-imx-sdma.txt | 1 +
> arch/arm/boot/dts/imx51.dtsi | 4 ++--
> arch/arm/boot/dts/imx53.dtsi | 4 ++--
> arch/arm/boot/dts/imx6qdl.dtsi | 12 +++++-----
> arch/arm/boot/dts/imx6sl.dtsi | 12 +++++-----
> drivers/dma/imx-sdma.c | 19 ++++++++++++++-
> include/linux/platform_data/dma-imx-sdma.h | 5 ++++
> include/linux/platform_data/dma-imx.h | 1 +
> sound/soc/fsl/fsl_ssi.c | 27 +++++++++++++++++++++-
> 9 files changed, 67 insertions(+), 18 deletions(-)
>
> --
> 1.8.4
>
>
--
^ permalink raw reply [flat|nested] 8+ messages in thread