From: Lukas Wunner <lukas@wunner.de>
To: linux-acpi@vger.kernel.org, devel@acpica.org
Cc: Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
platform-driver-x86@vger.kernel.org, "Lee,
Chun-Yi" <jlee@suse.com>, Mark Brown <broonie@kernel.org>,
Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>
Subject: [PATCH 0/5] Add acpi_dev_present
Date: Mon, 23 Nov 2015 15:34:55 +0100 [thread overview]
Message-ID: <cover.1448282995.git.lukas@wunner.de> (raw)
Hi everyone,
I need to detect the presence of apple-gmux (ACPI HID "APP000B")
in several DRM drivers to handle backlight, runtime pm and
deferred probing properly.
There's an idiom in use by 7 other drivers to detect presence of
a particular ACPI HID which involves calling acpi_get_devices()
and passing it a minimal callback that does no further filtering.
However this approach results in lots of duplicate code.
This series adds acpi_dev_present(), the ACPI equivalent to
pci_dev_present(). It takes a HID string and returns a bool,
allowing us to simplify the drivers considerably by removing
all the duplicate callbacks and other boilerplate.
I've pushed these patches to GitHub to ease reviewing:
https://github.com/l1k/linux/commits/acpi_dev_present
Should this series find acceptance, it would probably be best if
we could agree to merge everything through a single repository,
e.g. acpi (git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm).
or alternatively alsa (which contains 5 of the 7 drivers involved).
Consequently I would like to invite the driver maintainers to
kindly provide acks (or raise objections, if any).
The series should not result in any functional changes, however
I lack the hardware to actually verify this for every driver
involved. I did test it with apple-gmux though.
Thanks,
Lukas
Lukas Wunner (5):
ACPICA: Add acpi_dev_present
eeepc-wmi: Use acpi_dev_present
acer-wmi: Use acpi_dev_present
ALSA: hda - Use acpi_dev_present
ASoC: Intel: Use acpi_dev_present
drivers/acpi/acpica/nsxfeval.c | 46 ++++++++++++++++++++++++++++
drivers/platform/x86/acer-wmi.c | 16 +++-------
drivers/platform/x86/eeepc-wmi.c | 24 ++-------------
include/acpi/acpixf.h | 7 +++++
sound/pci/hda/thinkpad_helper.c | 17 ++--------
sound/soc/intel/atom/sst/sst_acpi.c | 12 +-------
sound/soc/intel/boards/cht_bsw_max98090_ti.c | 17 ++--------
sound/soc/intel/boards/cht_bsw_rt5645.c | 13 +-------
sound/soc/intel/common/sst-acpi.c | 12 +-------
9 files changed, 66 insertions(+), 98 deletions(-)
--
1.8.5.2 (Apple Git-48)
next reply other threads:[~2015-11-23 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:34 Lukas Wunner [this message]
2015-11-23 14:34 ` [PATCH 4/5] ALSA: hda - Use acpi_dev_present Lukas Wunner
2015-11-24 1:51 ` [alsa-devel] " Hui Wang
2015-11-23 14:34 ` [PATCH 1/5] ACPICA: Add acpi_dev_present Lukas Wunner
2015-11-23 22:34 ` Rafael J. Wysocki
2015-11-23 22:22 ` Moore, Robert
2015-11-23 23:32 ` Lukas Wunner
2015-11-24 4:40 ` Hanjun Guo
2015-11-24 14:15 ` Moore, Robert
2015-11-24 14:22 ` Rafael J. Wysocki
2015-11-24 14:54 ` Hanjun Guo
2015-11-23 14:34 ` [PATCH 5/5] ASoC: Intel: Use acpi_dev_present Lukas Wunner
2015-11-23 14:48 ` Mark Brown
2015-11-23 22:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1448282995.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=devel@acpica.org \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=jlee@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).