alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/18] treewide: Move storage class before return type
@ 2017-07-05 20:02 Joe Perches
  2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: Move inline " Joe Perches
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-07-05 20:02 UTC (permalink / raw)
  To: Andrew Morton, kvm, linux-arm-kernel, kvmarm, linux-m68k,
	linux-efi, linux-s390, linux-serial, linux-ia64, linux-usb,
	linux-fbdev, linux-omap, alsa-devel
  Cc: linux-mips, linux-kernel, linux-cris-kernel, linux-sh

Move the inline/asmlinkage keywords before the return types
Add a checkpatch test for this too.

Joe Perches (18):
  checkpatch: improve the STORAGE_CLASS test
  ARM: KVM: Move asmlinkage before type
  ARM: HP Jornada 7XX: Move inline before return type
  CRIS: gpio: Move inline before return type
  FRV: tlbflush: Move asmlinkage before return type
  ia64: Move inline before return type
  ia64: sn: pci: Move inline before type
  m68k: coldfire: Move inline before return type
  MIPS: SMP: Move asmlinkage before return type
  sh: Move inline before return type
  x86/efi: Move asmlinkage before return type
  drivers: s390: Move static and inline before return type
  drivers: tty: serial: Move inline before return type
  USB: serial: safe_serial: Move __inline__ before return type
  video: fbdev: intelfb: Move inline before return type
  video: fbdev: omap: Move inline before return type
  ARM: samsung: usb-ohci: Move inline before return type
  ALSA: opl4: Move inline before return type

 arch/arm/include/asm/kvm_hyp.h                 |  8 ++++----
 arch/arm/mach-sa1100/jornada720_ssp.c          |  2 +-
 arch/cris/arch-v10/drivers/gpio.c              |  4 ++--
 arch/frv/include/asm/tlbflush.h                |  8 ++++----
 arch/ia64/kernel/mca.c                         |  2 +-
 arch/ia64/sn/pci/pcibr/pcibr_ate.c             |  2 +-
 arch/ia64/sn/pci/tioce_provider.c              |  4 ++--
 arch/m68k/coldfire/intc-simr.c                 |  4 ++--
 arch/mips/include/asm/smp.h                    |  2 +-
 arch/sh/mm/cache-sh5.c                         |  2 +-
 arch/x86/include/asm/efi.h                     |  4 ++--
 drivers/s390/net/ctcm_main.c                   |  2 +-
 drivers/s390/net/qeth_l3_main.c                |  2 +-
 drivers/tty/serial/ioc3_serial.c               |  4 ++--
 drivers/tty/serial/ioc4_serial.c               |  4 ++--
 drivers/usb/serial/safe_serial.c               |  2 +-
 drivers/video/fbdev/intelfb/intelfbdrv.c       |  2 +-
 drivers/video/fbdev/omap/lcdc.c                |  6 +++---
 include/linux/platform_data/usb-ohci-s3c2410.h |  2 +-
 scripts/checkpatch.pl                          | 12 ++++++++++--
 sound/drivers/opl4/opl4_lib.c                  |  2 +-
 21 files changed, 44 insertions(+), 36 deletions(-)

-- 
2.10.0.rc2.1.g053435c

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 18/18] ALSA: opl4: Move inline before return type
  2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
@ 2017-07-05 20:02 ` Joe Perches
  2017-07-05 20:30   ` Clemens Ladisch
  2017-07-06  7:24   ` Takashi Iwai
  0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2017-07-05 20:02 UTC (permalink / raw)
  To: Andrew Morton, Clemens Ladisch; +Cc: linux-kernel, alsa-devel, Takashi Iwai

Make the code like the rest of the kernel.

Signed-off-by: Joe Perches <joe@perches.com>
---
 sound/drivers/opl4/opl4_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/drivers/opl4/opl4_lib.c b/sound/drivers/opl4/opl4_lib.c
index bc345d564f8d..db76a5bf2bd2 100644
--- a/sound/drivers/opl4/opl4_lib.c
+++ b/sound/drivers/opl4/opl4_lib.c
@@ -29,7 +29,7 @@ MODULE_AUTHOR("Clemens Ladisch <clemens@ladisch.de>");
 MODULE_DESCRIPTION("OPL4 driver");
 MODULE_LICENSE("GPL");
 
-static void inline snd_opl4_wait(struct snd_opl4 *opl4)
+static inline void snd_opl4_wait(struct snd_opl4 *opl4)
 {
 	int timeout = 10;
 	while ((inb(opl4->fm_port) & OPL4_STATUS_BUSY) && --timeout > 0)
-- 
2.10.0.rc2.1.g053435c

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 18/18] ALSA: opl4: Move inline before return type
  2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: Move inline " Joe Perches
@ 2017-07-05 20:30   ` Clemens Ladisch
  2017-07-06  7:24   ` Takashi Iwai
  1 sibling, 0 replies; 4+ messages in thread
From: Clemens Ladisch @ 2017-07-05 20:30 UTC (permalink / raw)
  To: Joe Perches, Andrew Morton; +Cc: linux-kernel, alsa-devel, Takashi Iwai

Joe Perches wrote:
> Make the code like the rest of the kernel.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  sound/drivers/opl4/opl4_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/drivers/opl4/opl4_lib.c b/sound/drivers/opl4/opl4_lib.c
> index bc345d564f8d..db76a5bf2bd2 100644
> --- a/sound/drivers/opl4/opl4_lib.c
> +++ b/sound/drivers/opl4/opl4_lib.c
> @@ -29,7 +29,7 @@ MODULE_AUTHOR("Clemens Ladisch <clemens@ladisch.de>");
>  MODULE_DESCRIPTION("OPL4 driver");
>  MODULE_LICENSE("GPL");
>
> -static void inline snd_opl4_wait(struct snd_opl4 *opl4)
> +static inline void snd_opl4_wait(struct snd_opl4 *opl4)
>  {
>  	int timeout = 10;
>  	while ((inb(opl4->fm_port) & OPL4_STATUS_BUSY) && --timeout > 0)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 18/18] ALSA: opl4: Move inline before return type
  2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: Move inline " Joe Perches
  2017-07-05 20:30   ` Clemens Ladisch
@ 2017-07-06  7:24   ` Takashi Iwai
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-07-06  7:24 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Andrew Morton, Clemens Ladisch, alsa-devel

On Wed, 05 Jul 2017 22:02:27 +0200,
Joe Perches wrote:
> 
> Make the code like the rest of the kernel.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-06  7:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: Move inline " Joe Perches
2017-07-05 20:30   ` Clemens Ladisch
2017-07-06  7:24   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).