From: Raghu Bankapur <quic_rbankapu@quicinc.com>
To: Vinod Koul <vkoul@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
Raghu Bankapur <quic_rbankapu@quicinc.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Cc: Krishna Jha <quic_kkishorj@quicinc.com>
Subject: [PATCH V0 0/1] ASoC: msm: fix integer overflow for long duration compress offload playback
Date: Wed, 9 Mar 2022 19:52:27 +0530 [thread overview]
Message-ID: <cover.1646835508.git.quic_rbankapu@quicinc.com> (raw)
32 bit variable is used for storing number of bytes copied to DSP,
which can overflow when playback duration goes beyond 24 hours.
Change data type for this variable to uint64_t to prevent overflow
and related playback anomaly.
below are the steps used to reproduce
Steps:-
1. play all clips from music app with Repeat All Songs enabled
2. one of clip is 1hr duration - 5.1_16bit_192khz_1hr.m4a
3. ACTUAL BEHAVIOUR:- there is no audio playback & progress bar was at
end of stream, but time stamp continues to update till 31hrs for 1hr clip
Raghu Bankapur (1):
ASoC: msm: fix integer overflow for long duration offload playback
include/uapi/sound/compress_offload.h | 2 +-
sound/core/compress_offload.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
next reply other threads:[~2022-03-09 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:22 Raghu Bankapur [this message]
2022-03-09 14:22 ` [PATCH V0 1/1] ASoC: msm: fix integer overflow for long duration offload playback Raghu Bankapur
2022-03-09 14:51 ` Amadeusz Sławiński
2022-03-09 15:15 ` Pierre-Louis Bossart
2022-03-09 18:23 ` kernel test robot
2022-03-09 22:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1646835508.git.quic_rbankapu@quicinc.com \
--to=quic_rbankapu@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_kkishorj@quicinc.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).