Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Geoffrey D. Bennett" <g@b4.vu>
To: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, Philippe Perrot <philippe@perrot-net.fr>
Subject: [PATCH 0/4] ALSA: scarlett2: Driver updates
Date: Fri, 15 Sep 2023 03:01:37 +0930	[thread overview]
Message-ID: <cover.1694705811.git.g@b4.vu> (raw)

Hi Takashi,

I think it's time to enable this driver by default because:

- Early versions of this mixer driver did not work on all hardware, so
  out of caution the driver was disabled by default and had to be
  explicitly enabled with device_setup=1.

- Since commit 764fa6e686e0 ("ALSA: usb-audio: scarlett2: Fix device
  hang with ehci-pci") (21/May/2021) no more problems of this nature
  have been reported.

- Therefore, patch 1 in this series proposes to enable the driver by
  default, but provide a new device_setup option to disable the driver
  in case that is needed.

Patch 3 adds support for the Clarett 8Pre USB. This is the first
device supported by this driver which is controlled identically to
another, so patch 2 first allows sharing the device_info struct
between models.

Patch 4 adds the specific product series name (like "Scarlett Gen 2")
to various messages so the text is correct without being unwieldy &
generic (like "Scarlett Gen 2/3/Clarett USB/Clarett+").

Geoffrey D. Bennett (4):
  ALSA: scarlett2: Default mixer driver to enabled
  ALSA: scarlett2: Move USB IDs out from device_info struct
  ALSA: scarlett2: Add support for Clarett 8Pre USB
  ALSA: scarlett2: Add correct product series name to messages

 sound/usb/mixer_quirks.c        |   1 +
 sound/usb/mixer_scarlett_gen2.c | 148 ++++++++++++++++++--------------
 2 files changed, 83 insertions(+), 66 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-14 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 17:31 Geoffrey D. Bennett [this message]
2023-09-14 17:31 ` [PATCH 1/4] ALSA: scarlett2: Default mixer driver to enabled Geoffrey D. Bennett
2023-09-14 17:32 ` [PATCH 2/4] ALSA: scarlett2: Move USB IDs out from device_info struct Geoffrey D. Bennett
2023-09-14 17:32 ` [PATCH 3/4] ALSA: scarlett2: Add support for Clarett 8Pre USB Geoffrey D. Bennett
2023-09-14 17:33 ` [PATCH 4/4] ALSA: scarlett2: Add correct product series name to messages Geoffrey D. Bennett
2023-09-18 15:48 ` [PATCH 0/4] ALSA: scarlett2: Driver updates Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1694705811.git.g@b4.vu \
    --to=g@b4.vu \
    --cc=alsa-devel@alsa-project.org \
    --cc=philippe@perrot-net.fr \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox