From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Torsten Schenk <torsten.schenk@zoho.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] ALSA: 6fire: Fix undefined behavior bug in struct midi_runtime
Date: Sun, 1 Oct 2023 08:53:30 +0200 [thread overview]
Message-ID: <d044b556-d97f-218f-4282-5d87be6a8ef9@embeddedor.com> (raw)
In-Reply-To: <202309291026.06071AC@keescook>
On 9/29/23 19:27, Kees Cook wrote:
> On Fri, Sep 29, 2023 at 06:06:32PM +0200, Gustavo A. R. Silva wrote:
>> `struct urb` is a flexible structure, which means that it contains a
>> flexible-array member at the bottom. This could potentially lead to an
>> overwrite of the objects following `out_urb` in `struct midi_runtime`,
>> among them a function pointer.
>>
>> Fix this by placing the declaration of object `out_urb` at the end of
>> `struct midi_runtime`.
>>
>> Fixes: c6d43ba816d1 ("ALSA: usb/6fire - Driver for TerraTec DMX 6Fire USB")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Another good find. :)
There are more coming. :)
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Thanks!
--
Gustavo
next prev parent reply other threads:[~2023-10-01 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:06 [PATCH][next] ALSA: 6fire: Fix undefined behavior bug in struct midi_runtime Gustavo A. R. Silva
2023-09-29 17:27 ` Kees Cook
2023-10-01 6:53 ` Gustavo A. R. Silva [this message]
2023-10-06 9:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d044b556-d97f-218f-4282-5d87be6a8ef9@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=alsa-devel@alsa-project.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=torsten.schenk@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).