From: <tanureal@opensource.cirrus.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
David Rhodes <drhodes@opensource.cirrus.com>
Subject: Re: [PATCH v2 01/20] ASoC: cs35l41: Fix GPIO2 configuration
Date: Fri, 4 Mar 2022 15:44:15 +0000 [thread overview]
Message-ID: <d2b9dbba-b255-53d4-4698-ac233e6159d9@opensource.cirrus.com> (raw)
In-Reply-To: <20220304152226.GE38351@ediswmail.ad.cirrus.com>
On 3/4/22 3:22 PM, Charles Keepax <ckeepax@opensource.cirrus.com> wrote:
> On Fri, Mar 04, 2022 at 03:07:02PM +0000, Lucas Tanure wrote:
> > From: David Rhodes <drhodes@opensource.cirrus.com>
> >
> > Fix GPIO2 polarity and direction configuration
> >
> > Fixes: fe1024d50477b ("ASoC: cs35l41: Combine adjacent register writes")
> > Signed-off-by: David Rhodes <drhodes@opensource.cirrus.com>
> > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
>
> Really sorry I only just spotted this but you are missing your
> own sign off here. You always need to personally sign each patch
> you are sending up.
>
> Thanks,
> Charles
>
Yes, sorry about that. I will give some time for more reviews on this version and fix it on v3.
next prev parent reply other threads:[~2022-03-04 15:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 15:07 [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 01/20] ASoC: cs35l41: Fix GPIO2 configuration Lucas Tanure
2022-03-04 15:22 ` Charles Keepax
2022-03-04 15:44 ` tanureal [this message]
2022-03-04 15:07 ` [PATCH v2 02/20] ASoC: cs35l41: Fix max number of TX channels Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 03/20] ASoC: cs35l41: Fix DSP mbox start command and global enable order Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 04/20] ASoC: cs35l41: Remove unnecessary param Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 05/20] sound: cs35l41: Unify hardware configuration Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 06/20] sound: cs35l41: Check hw_config before using it Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 07/20] sound: cs35l41: Move cs35l41_gpio_config to shared lib Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 08/20] hda: cs35l41: Fix I2S params comments Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 09/20] hda: cs35l41: Always configure the DAI Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 10/20] hda: cs35l41: Add Boost type flag Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 11/20] hda: cs35l41: Put the device into safe mode for external boost Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 12/20] hda: cs35l41: Mute the device before shutdown Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 13/20] sound: cs35l41: Enable Internal Boost in shared lib Lucas Tanure
2022-03-04 16:17 ` Charles Keepax
2022-03-04 15:07 ` [PATCH v2 14/20] hda: cs35l41: Move boost config to initialization code Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 15/20] hda: cs35l41: Remove cs35l41_hda_reg_sequence struct Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 16/20] hda: cs35l41: Reorganize log for playback actions Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 17/20] hda: cs35l41: Handle all external boost setups the same way Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 18/20] hda: cs35l41: Move external boost handling to lib for ASoC use Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 19/20] ASoC: cs35l41: Support external boost Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 20/20] ASoC: cs35l41: Document CS35l41 External Boost Lucas Tanure
2022-03-04 17:05 ` [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver Takashi Iwai
2022-03-07 20:38 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b9dbba-b255-53d4-4698-ac233e6159d9@opensource.cirrus.com \
--to=tanureal@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=drhodes@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox