From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C124EC2BA19 for ; Tue, 14 Apr 2020 18:19:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4767A2076A for ; Tue, 14 Apr 2020 18:19:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="a9+roJmC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4767A2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 911491692; Tue, 14 Apr 2020 20:18:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 911491692 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586888387; bh=g8XxEuGvkW3QZN1to2dOAopNFSxEV5tPajKzUlfZ6Y0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a9+roJmCs3+cEHoZGtt70C7S0/auqcEG6hP26+gq0zPIhx6/eOnrkuuEVuoXztx0O UuXQzuKtWZN5FGXnu9BeDvphj+yvQqeW1qTiZZa9olDHCsrM0JJrouXLDtQshikJxk zf3ghaFjic9onDLBWSKsXJAHeK6r/KeS0d+zUZcM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 673B1F8029B; Tue, 14 Apr 2020 20:17:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5A327F802A0; Tue, 14 Apr 2020 20:17:04 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8D066F80292 for ; Tue, 14 Apr 2020 20:16:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8D066F80292 IronPort-SDR: B3KttiPURol3IFd7u09cSqjsH4lGq0W/Sh6/elce0EnrYb6ZSlQiXGbjbnwWEC41OYYSqe3yT4 HrYde/jYTf9g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 11:16:56 -0700 IronPort-SDR: PSCQxYOBgG/KRnSVwz6t0T307zmoiAEV1+rS7DuMMYdAflRVrE4k7RQuT8DDDeP3LYxtQ8Ysh2 IjarvwZ20lXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,383,1580803200"; d="scan'208";a="253272925" Received: from svarahab-mobl.amr.corp.intel.com (HELO [10.212.190.40]) ([10.212.190.40]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2020 11:16:53 -0700 Subject: Re: [RFC PATCH 04/16] ASoC: Intel: sof-pcm512x: detect Hifiberry DAC+ PRO To: Andy Shevchenko References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-5-pierre-louis.bossart@linux.intel.com> <20200414172002.GD34613@smile.fi.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 14 Apr 2020 13:02:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200414172002.GD34613@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Matthias Reichl , tiwai@suse.de, Linus Walleij , Stephen Boyd , Daniel Matuschek , linux-clk@vger.kernel.org, Hui Wang , linux-gpio@vger.kernel.org, Rob Herring , broonie@kernel.org, Bartosz Golaszewski , Michael Turquette X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 4/14/20 12:20 PM, Andy Shevchenko wrote: > On Thu, Apr 09, 2020 at 02:58:29PM -0500, Pierre-Louis Bossart wrote: >> Try to detect HifiBerry 44.1 and 48kHz oscillators on codec init > > ... > >> + ctx->sclk = devm_clk_get(rtd->card->dev, "sclk"); > > Is this in the bindings? Not for now. the 'sclk' part is only used by me myself and I in an ACPI context. I can add this description if desired. > >> + if (IS_ERR(ctx->sclk)) { > >> + dev_info(dev, "Could not get SCLK, will operate in SOC master mode\n"); > > Sounds like devm_clk_get_optional(). I am not sure about the semantic here. This driver selects the one which implements this clock, so if we get a -ENOENT return it's a very bad sign. Not sure what suppressing the error and converting to NULL would do? > >> + goto skip_dacpro; >> + } >