From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] ASoC: ti: Convert RX51 to use exclusively GPIO descriptors
Date: Sun, 1 Oct 2023 20:48:06 +0300 [thread overview]
Message-ID: <d402fbdb-fba7-412b-ae1e-470ad253981e@bitmer.com> (raw)
In-Reply-To: <20230926-descriptors-asoc-ti-v1-2-60cf4f8adbc5@linaro.org>
On 9/26/23 16:25, Linus Walleij wrote:
> The RX51/Nokia n900 uses the legacy GPIO header to convert a GPIO
> back to the global GPIO numberspace and then the jack using it
> in the snd_soc_jack_add_gpios() call immediately looks up the
> corresponding descriptor again.
>
> The snd_soc_jack_add_gpios() handles GPIOs passed with devices
> just fine: pass in the device instead, and rename the GPIO
> to match the property in the device tree, and it should work
> all the same but without all the trouble.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2023-10-01 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 13:25 [PATCH 0/5] GPIO descriptors for TI ASoC codecs Linus Walleij
2023-09-26 13:25 ` [PATCH 1/5] ASoC: ti: Convert N810 ASoC to GPIO descriptors Linus Walleij
2023-09-26 13:25 ` [PATCH 2/5] ASoC: ti: Convert RX51 to use exclusively " Linus Walleij
2023-10-01 17:48 ` Jarkko Nikula [this message]
2023-09-26 13:25 ` [PATCH 3/5] ASoC: ti: Convert TWL4030 to use " Linus Walleij
2023-09-26 13:25 ` [PATCH 4/5] ASoC: ti: Convert Pandora ASoC to " Linus Walleij
2023-09-26 13:25 ` [PATCH 5/5] ASoC: ti: osk5912: Drop unused include Linus Walleij
2023-10-01 17:49 ` [PATCH 0/5] GPIO descriptors for TI ASoC codecs Jarkko Nikula
2023-10-02 11:45 ` Mark Brown
2023-10-02 16:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d402fbdb-fba7-412b-ae1e-470ad253981e@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).