From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF14EC11D05 for ; Thu, 20 Feb 2020 15:09:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8018D208CD for ; Thu, 20 Feb 2020 15:09:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="c3wLdg+l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="WdHPV5jT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8018D208CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E344216BC; Thu, 20 Feb 2020 16:08:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E344216BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582211348; bh=IsMRCtbeAkobDvJcSJu9wAvgMOS2B90Xx1HZTmWmeIY=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=c3wLdg+lp4aw55KZNmVEcSOfvBn+H7JDdBIAiTdbHqTDoNGJjzjdLgrWyzE9efQCI QCzGfuZTSMDe271YT+nzZ0Y0Tlvfc6Y1cxigj2hNK+VmLyn/geIoHb8EZmiq4kaOI5 draZu4IjxRpz2d2M3tItUUTXij6mfp0Ume2CV4LA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 683CFF80145; Thu, 20 Feb 2020 16:08:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EA749F80148; Thu, 20 Feb 2020 16:08:14 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34E31F80101 for ; Thu, 20 Feb 2020 16:08:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34E31F80101 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="WdHPV5jT" Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 20 Feb 2020 07:06:56 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 20 Feb 2020 07:08:08 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 20 Feb 2020 07:08:08 -0800 Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 20 Feb 2020 15:08:05 +0000 Subject: Re: [PATCH v3 05/10] ASoC: tegra: add Tegra210 based AHUB driver To: Sameer Pujar , , , References: <1582180492-25297-1-git-send-email-spujar@nvidia.com> <1582180492-25297-6-git-send-email-spujar@nvidia.com> From: Jon Hunter Message-ID: Date: Thu, 20 Feb 2020 15:08:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1582180492-25297-6-git-send-email-spujar@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582211216; bh=1fxGENVsrBJEQvVJW5203qUrMQ2k8GsjvtaSYcWTupg=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=WdHPV5jTvllydXKqWZyKo6EBlgdMZLp/IxTT1Aw7dvi/Fg/i9tcpwbLRgqoFEOiDP Ot29wZkYEN0vaVQ//R+yG/uYnD8pOVwRnKpTf17zUsjqVxG/0y7/6WSbfQ1Duca6un sLTZS5OdHNpEkncE29OMirsLCGIRJmkGrVQCP76FGGVTHaLXrOupWqivrgoREHb8jw R80vLvNjtFaphj5Una7wahQJSgPioMKQ5MZl+hb2LSYQ+w8MKgZj14OBQSovO+3Sya dZhjFY/rlY4VugyU/hoFWgXEdNO9u6m3smwK8QwP0BvBdvDEXcahbITGg+Wvn5yLVK dYMm4GbS/9g+w== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, digetx@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 20/02/2020 06:34, Sameer Pujar wrote: > The Audio Hub (AHUB) comprises a collection of hardware accelerators for > audio pre/post-processing and a programmable full crossbar (XBAR) for > routing audio data across these accelerators in time and in parallel. > AHUB supports multiple interfaces to I2S, DSPK, DMIC etc., XBAR is a > switch used to configure or modify audio routing between HW accelerators > present inside AHUB. > > This patch registers AHUB component with ASoC framework. The component > driver exposes DAPM widgets, routes and kcontrols for the device. The DAI > driver exposes AHUB interfaces, which can be used to connect different > components in the ASoC layer. Currently the driver takes care of XBAR > programming to allow audio data flow through various clients of the AHUB. > Makefile and Kconfig support is added to allow to build the driver. The > AHUB component can be enabled in the DT via below compatible bindings. > - "nvidia,tegra210-ahub" for Tegra210 > - "nvidia,tegra186-ahub" for Tegra186 and Tegra194 > > Signed-off-by: Sameer Pujar > --- > sound/soc/tegra/Kconfig | 10 + > sound/soc/tegra/Makefile | 2 + > sound/soc/tegra/tegra210_ahub.c | 651 ++++++++++++++++++++++++++++++++++++++++ > sound/soc/tegra/tegra210_ahub.h | 125 ++++++++ > 4 files changed, 788 insertions(+) > create mode 100644 sound/soc/tegra/tegra210_ahub.c > create mode 100644 sound/soc/tegra/tegra210_ahub.h Aside from Randy's comment ... Reviewed-by: Jon Hunter Cheers Jon -- nvpublic