From: <AJ_Cheng@compal.com>
To: <intel-gfx@lists.freedesktop.org>, <alsa-devel@alsa-project.org>
Cc: nathan.d.ciobanu@linux.intel.com, CindyXT_Wang@compal.com,
Nelson_Ye@compal.com, Shane_Yap@compal.com,
Lucien_Kao@compal.com, Evan_Tseng@compal.com
Subject: [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor
Date: Fri, 3 Jan 2020 01:57:03 +0000 [thread overview]
Message-ID: <d7aba6970fbd48f2b32e2bc6d838ab20@TPEMBX01.compal.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
Hi Sirs,
Here is chromebook SW team from Compal.
As the mail title, we hit issue that the external monitor will flash once when play video after hot pluging.
We can reproduce not only on chromebook but also ubuntu 16.04.
There has higher failure rate with Dell Solomon dock and Dell S2718D monitor.
We found adding the delay in "sound/pci/hda/patch_hdmi.c " can fix this issue.(as the attachment)
May need your help to review and advice. Thanks.
Here is the issue number in gitlab for more detail.
https://gitlab.freedesktop.org/drm/intel/issues/318
AJ Cheng
NID/NID1
e-mail: AJ_Cheng@compal.com<mailto:AJ_Cheng@compal.com>
Tel: +886-2-8797-8599 ext. 17561
Mobile : +886-932827829
COMPAL Electronics, Inc.
[-- Attachment #2: flash_once.diff --]
[-- Type: application/octet-stream, Size: 593 bytes --]
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 4448ab6..77dc6b9 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -854,7 +854,7 @@ static void haswell_verify_D0(struct hda_codec *codec,
* converters are in correct power state */
if (!snd_hda_check_power_state(codec, cvt_nid, AC_PWRST_D0))
snd_hda_codec_write(codec, cvt_nid, 0, AC_VERB_SET_POWER_STATE, AC_PWRST_D0);
-
+ msleep(40);
if (!snd_hda_check_power_state(codec, nid, AC_PWRST_D0)) {
snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_POWER_STATE,
AC_PWRST_D0);
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2020-01-03 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 1:57 AJ_Cheng [this message]
2020-01-03 9:16 ` [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor Takashi Iwai
2020-01-06 8:08 ` Lucien_Kao
2020-01-07 17:24 ` Nathan Ciobanu
2020-01-07 18:57 ` Takashi Iwai
2020-01-08 3:07 ` Lucien_Kao
2020-01-08 6:17 ` Takashi Iwai
2020-02-12 9:37 ` Lucien_Kao
2020-02-12 10:03 ` Takashi Iwai
2020-02-13 3:00 ` Lucien_Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7aba6970fbd48f2b32e2bc6d838ab20@TPEMBX01.compal.com \
--to=aj_cheng@compal.com \
--cc=CindyXT_Wang@compal.com \
--cc=Evan_Tseng@compal.com \
--cc=Lucien_Kao@compal.com \
--cc=Nelson_Ye@compal.com \
--cc=Shane_Yap@compal.com \
--cc=alsa-devel@alsa-project.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nathan.d.ciobanu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox