From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Cc: "Cezary Rojewski" <cezary.rojewski@intel.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Curtis Malainey" <cujomalainey@google.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>
Subject: ASoC component/card relationship
Date: Fri, 29 Apr 2022 16:55:18 -0500 [thread overview]
Message-ID: <d9c3fed4-de6a-2cd8-acb6-7f3d2ad46b70@linux.intel.com> (raw)
Hi,
In the existing ASoC code, there is a fixed mapping between ASoC card and component. A component relies on a ->card pointer that is set during the probe. A component cannot be used by or "bound to" more than one card [1]
This has interesting impacts on how a codec or DSP driver need to be implemented.
In the AVS series posted this week, multiple components are registered by the DSP driver, following an interface-based split. There's in addition a second-level split, where the logic is pushed further: the DSP driver partitions the SSP DAIs in different set of 'dai_driver's used by different components, which are in turn used by different cards. What is done in these patches is not wrong, and is probably the only solution to support a real-world platform with the existing ASoC code, but are the framework assumptions correct? In this example, the board-level information on which interface is used for what functionality trickles down to the lowest level of the DSP driver implementation.
I believe this breaks to some extent the 'clean' split between platform and machine driver(s), and it's not quite aligned with the usual notion of register/probe used across frameworks, be it for drivers/clocks/you name it.
A similar case could happen in a codec driver, if independent functionality such as headset and amplifier support was exposed by separate cards, that would in turn mandate that the codec driver exposed N components, each handling different functionality but the same type of DAI.
An alternative approach would be that the DSP driver exposes all the possible DAIs that can be used, and the binding is refined to allow for more flexibility. I think it's really the individual DAI that cannot be used by more than one card.
I figured I would ask on this mailing list if
a) I am not mistaken on the component/card relationship and
b) if this is by design, or if we want to clarify what a component is and what its restrictions might be.
Thanks for your feedback/comments
-Pierre
[1] https://elixir.bootlin.com/linux/latest/source/sound/soc/soc-core.c#L1364
next reply other threads:[~2022-04-29 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 21:55 Pierre-Louis Bossart [this message]
2022-04-29 22:32 ` ASoC component/card relationship Curtis Malainey
2022-05-02 15:06 ` Pierre-Louis Bossart
2022-05-02 20:06 ` Curtis Malainey
2022-05-03 18:10 ` Mark Brown
2022-05-03 18:59 ` Pierre-Louis Bossart
2022-05-03 20:31 ` Mark Brown
2022-05-03 21:42 ` Pierre-Louis Bossart
2022-05-04 9:21 ` Amadeusz Sławiński
2022-05-04 15:26 ` Pierre-Louis Bossart
2022-05-04 15:38 ` Jaroslav Kysela
2022-05-04 16:00 ` Cezary Rojewski
2022-05-04 16:27 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9c3fed4-de6a-2cd8-acb6-7f3d2ad46b70@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@google.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox