From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C208C433F5 for ; Mon, 28 Mar 2022 07:07:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 50B1CAE8; Mon, 28 Mar 2022 09:06:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 50B1CAE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1648451266; bh=Od98xWiyL6O260yMUyhOtW1OV9LDX9NwBH3M02xHCGA=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q49mAcHn/704koyk1zt5/KMC0b87k1bth/UJpaAF1DzOm7IYy+KoPLNyrRPkNxw9s J72n9W9Y6rGikzEmVE9w09Q1Tt1ogRNqLZAv4jikHltI7rxRgYE6xqdsKNvVWDvZuw yogskqp0hU0aYiqE6wJOPOTNy/20bFL2f+8nx0cA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E3BA6F80128; Mon, 28 Mar 2022 09:06:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0872BF800FA; Mon, 28 Mar 2022 09:06:55 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1F2C3F800FA for ; Mon, 28 Mar 2022 09:06:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1F2C3F800FA Received: by mail-ed1-f42.google.com with SMTP id y10so15738872edv.7 for ; Mon, 28 Mar 2022 00:06:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bWHNH/EfXpoNd6GDO+NCVI8AReob2nLGcB93Fy6VsBU=; b=d0FpkGStzwZQMSXqahXbD5EXNuRNJOSwNGCgt5V2jJSygkyJJd02V1aq8atkuJjm0u OILU43OsfpvstVVh3/8TEJDTBBwMS2I//N6xgVOSGJYRSmmdYRdTK2x5rVU6zE+r+jkD 8RskSliLyGBvGMeu0QbofGXtAysjbjrAJkhW3MN6drIq+NF2kAyyPpQNu+4FHLZkNcCM Sbz02aOz2tWzgDUfhYCvqzotlc02iSwYMn0vuQaEv3SyZPZYMDaaoQPiiJHiWmXk8RA/ L8poBzrBEryTASRF7lImO7+l8Kd06CSIG8gj3NRU2r3viX8PdXxY/yrdW1VY3CZSV/ZQ tiAw== X-Gm-Message-State: AOAM532BnNh4BvEVuR+2B6ko8OXNIOMRSWqBjFeBShIYBdp0p0GEO5sP 43BYDRUUJZb02K+9BGXRn64= X-Google-Smtp-Source: ABdhPJyIknQbldb2sxGzz5k0GbACmYk7LHZl4P9ANNwRnBbA6fgve5eGIekXkq4wWYc5UHkwHDUhEQ== X-Received: by 2002:a05:6402:3496:b0:419:82d5:f1d9 with SMTP id v22-20020a056402349600b0041982d5f1d9mr14537977edc.36.1648451208200; Mon, 28 Mar 2022 00:06:48 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id k12-20020aa7c38c000000b0041939d9ccd0sm6618012edq.81.2022.03.28.00.06.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 00:06:47 -0700 (PDT) Message-ID: Date: Mon, 28 Mar 2022 09:06:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC PATCH v2 3/6] ASoC: dt-bindings: Extend clock bindings of rt5659 Content-Language: en-US To: Sameer Pujar , broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, krzk+dt@kernel.org, perex@perex.cz, tiwai@suse.com, peter.ujfalusi@linux.intel.com, pierre-louis.bossart@linux.intel.com References: <1648448050-15237-1-git-send-email-spujar@nvidia.com> <1648448050-15237-4-git-send-email-spujar@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: <1648448050-15237-4-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: oder_chiou@realtek.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 28/03/2022 08:14, Sameer Pujar wrote: > The rt5658 or rt5659 CODEC system clock (SYSCLK) can be derived from > various clock sources. For example it can be derived either from master > clock (MCLK) or by internal PLL. The internal PLL again can take input > clock references from bit clocks (BCLKs) and MCLK. To enable a flexible > clocking configuration the DT binding is extended here. > > It makes use of standard clock bindings and sets up the clock relation > via DT. > > Signed-off-by: Sameer Pujar > Cc: Oder Chiou > --- > .../devicetree/bindings/sound/realtek,rt5659.yaml | 53 ++++++++++++++++++++-- > 1 file changed, 49 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml > index b0485b8..0c2f3cb 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5659.yaml > @@ -29,12 +29,28 @@ properties: > maxItems: 1 > > clocks: > - items: > - - description: Master clock (MCLK) to the CODEC > + description: | > + CODEC can receive multiple clock inputs like Master > + clock (MCLK), I2S bit clocks (BCLK1, BCLK2, BCLK3, > + BCLK4). The CODEC SYSCLK can be generated from MCLK > + or internal PLL. In turn PLL can reference from MCLK > + and BCLKs. > > clock-names: > - items: > - - const: mclk > + description: | > + The clock names can be combination of following: > + "mclk" : Master clock > + "pll_ref" : Reference to CODEC PLL clock > + "sysclk" : CODEC SYSCLK > + "^bclk[1-4]$" : Bit clocks to CODEC No, that does not look correct. You allow anything as clock input (even 20 clocks, different names, any order). That's not how DT schema should work and that's not how hardware looks like. Usually the clock inputs are always there which also you mentioned in description - "multiple clock inputs". All these clocks should be expected, unless really the wires (physical wires) can be left disconnected. Best regards, Krzysztof