Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>
Cc: "Cezary Rojewski" <cezary.rojewski@intel.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	"Łukasz Majczak" <lma@chromium.org>
Subject: Re: [PATCH 1/2] ASoC: Intel: avs: Add rt5514 machine board
Date: Sat, 28 Oct 2023 10:46:55 +0200	[thread overview]
Message-ID: <db8fb570-0532-45d2-b0dd-adfb8727f258@kernel.org> (raw)
In-Reply-To: <20231027110537.2103712-2-amadeuszx.slawinski@linux.intel.com>

On 27/10/2023 13:05, Amadeusz Sławiński wrote:
> To support AVS-rt5514 configuration add machine board connecting AVS
> platform component driver with rt5514 codec one.
> 
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
>  sound/soc/intel/avs/boards/Kconfig  |  10 ++
>  sound/soc/intel/avs/boards/Makefile |   2 +
>  sound/soc/intel/avs/boards/rt5514.c | 187 ++++++++++++++++++++++++++++
>  3 files changed, 199 insertions(+)
>  create mode 100644 sound/soc/intel/avs/boards/rt5514.c

...

> +
> +static struct platform_driver avs_rt5514_driver = {
> +	.probe = avs_rt5514_probe,
> +	.driver = {
> +		.name = "avs_rt5514",
> +		.pm = &snd_soc_pm_ops,
> +	},
> +};
> +
> +module_platform_driver(avs_rt5514_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:avs_rt5514");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong.

Best regards,
Krzysztof


  reply	other threads:[~2023-10-28  8:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 11:05 [PATCH 0/2] ASoC: Intel: avs: Add support for rt5514 codec Amadeusz Sławiński
2023-10-27 11:05 ` [PATCH 1/2] ASoC: Intel: avs: Add rt5514 machine board Amadeusz Sławiński
2023-10-28  8:46   ` Krzysztof Kozlowski [this message]
2023-10-30 11:50     ` Amadeusz Sławiński
2023-10-30 11:59       ` Krzysztof Kozlowski
2023-10-30 12:15         ` Amadeusz Sławiński
2023-10-30 12:46           ` Krzysztof Kozlowski
2023-10-27 11:05 ` [PATCH 2/2] " Amadeusz Sławiński
2023-10-27 22:54 ` [PATCH 0/2] ASoC: Intel: avs: Add support for rt5514 codec Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db8fb570-0532-45d2-b0dd-adfb8727f258@kernel.org \
    --to=krzk@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=lma@chromium.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox